This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Substrate 13843 (Asset Freezing) Companion#2437
Merged
Merged
Conversation
joepetrowski
added
A0-please_review
NachoPal
reviewed
Apr 10, 2023
NachoPal
left a comment
NachoPal
left a comment
Contributor
There was a problem hiding this comment.
We should consider if it really makes sense to run migrations in testing parachains (penpal and rococo-parachain). As testing parachains they are expected to start with a fresh state. Unless we have a live parachain using one of those runtimes I wouldn't bother adding/removing migrations there.
bkchr
approved these changes
Apr 11, 2023
muharem
approved these changes
Apr 11, 2023
Contributor
Author
|
bot rebase |
|
Rebased |
Contributor
|
bot rebase |
|
Rebased |
|
Waiting for commit status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion for paritytech/substrate#13843