Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

13110 Companion: Add WeightToFee and LengthToFee Runtime API#2073

Merged
paritytech-processbot[bot] merged 7 commits into
paritytech:masterfrom
notlesh:notlesh-substrate-13110-companion
Jan 27, 2023
Merged

13110 Companion: Add WeightToFee and LengthToFee Runtime API#2073
paritytech-processbot[bot] merged 7 commits into
paritytech:masterfrom
notlesh:notlesh-substrate-13110-companion

Conversation

@notlesh

@notlesh notlesh commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Companion for paritytech/substrate#13110.

This adds query_weight_to_fee and query_length_to_fee to each runtime API impl.

@paritytech-ci paritytech-ci requested review from a team January 10, 2023 17:53
@notlesh notlesh mentioned this pull request Jan 10, 2023
Merged
@ggwpez ggwpez added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T2-API This PR/Issue is related to APIs. labels Jan 26, 2023
@paritytech-processbot

paritytech-processbot Bot commented Jan 26, 2023

Copy link
Copy Markdown

Merge cancelled due to error. Error: Checks failed for fcca79c

@ggwpez ggwpez mentioned this pull request Jan 26, 2023
Merged
1 task
@ggwpez ggwpez added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jan 26, 2023
This was referenced Jan 26, 2023
Merged
Merged
@bkchr

bkchr commented Jan 27, 2023

Copy link
Copy Markdown
Member

bot rebase

@paritytech-processbot

paritytech-processbot Bot commented Jan 27, 2023

Copy link
Copy Markdown

Error: Command 'Command { std: "git" "push" "--porcelain" "notlesh" "notlesh-substrate-13110-companion", kill_on_drop: false }' failed with status Some(1); output: error: failed to push some refs to 'https://x-access-token:${SECRET}@github.com/notlesh/cumulus.git'

@paritytech-processbot

paritytech-processbot Bot commented Jan 27, 2023

Copy link
Copy Markdown

Merge cancelled due to error. Error: Command 'Command { std: "git" "push" "notlesh" "notlesh-substrate-13110-companion", kill_on_drop: false }' failed with status Some(1); output: To https://github.com/notlesh/cumulus.git
! [remote rejected] notlesh-substrate-13110-companion -> notlesh-substrate-13110-companion (refusing to allow a GitHub App to create or update workflow .github/workflows/check-D-labels.yml without workflows permission)
error: failed to push some refs to 'https://x-access-token:${SECRET}@github.com/notlesh/cumulus.git'

@bkchr bkchr removed the T2-API This PR/Issue is related to APIs. label Jan 27, 2023
@bkchr

bkchr commented Jan 27, 2023

Copy link
Copy Markdown
Member

bot merge

@paritytech-processbot

paritytech-processbot Bot commented Jan 27, 2023

Copy link
Copy Markdown

Waiting for commit status.

@paritytech-processbot paritytech-processbot Bot merged commit fd89a5b into paritytech:master Jan 27, 2023
@notlesh

notlesh commented Jan 27, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

@kiltbot kiltbot mentioned this pull request Feb 22, 2023
Closed
@Polkadot-Forum

Polkadot-Forum commented Feb 22, 2023

Copy link
Copy Markdown

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-38/2122/1

This was referenced Feb 22, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@notlesh @bkchr @Polkadot-Forum @ggwpez @joepetrowski