This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Introduce RPC Worker#1462
Merged
Merged
Conversation
skunert
added
A0-pleasereview
B0-silent
davxy
reviewed
Jul 27, 2022
Member
|
Really silly nit. Maybe we can stick to the notation where also the acronyms are usually written in camel case. Feel free to ignore me :-D |
koute
reviewed
Jul 27, 2022
davxy
reviewed
Jul 27, 2022
davxy
left a comment
davxy
left a comment
Member
There was a problem hiding this comment.
LGTM, I've just added a suggestion to set the RpcStreamWorker as private
davxy
approved these changes
Jul 27, 2022
Co-authored-by: Davide Galassi <davxy@datawok.net>
koute
approved these changes
Jul 29, 2022
bkchr
reviewed
Jul 29, 2022
bkchr
reviewed
Jul 29, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the next step towards #989.
Currently the collator opens a new RPC subscription every time we request a notification stream from the
RelayChainRPCInterface.After this PR is merged, we will have only three open notification subscriptionsvia RPC:
A worker is introduced that will poll these three subscriptions regularly and distribute the contained headers to all listening streams. Requesting a stream from the
RelayChainRPCInterfacewill return a new channel and inform the worker.Since the streams are only used in the collator, and we have complete control, we use bounded channels with a limit of 20 items.