Repository navigation
upgrade to Rust v1.99.0 - #23692
Merged
Merged
upgrade to Rust v1.99.0#23692
Conversation
```
error: this function has a `#[must_use]` attribute with no message, but returns a type already considered as `#[must_use]`
--> graph/src/node.rs:21:15
|
21 | #[async_trait]
| _______________^
22 | | pub trait Node: Clone + Debug + Display + Eq + Hash + Send + Sync + 'static {
23 | | /// An implementation-specific context required to run this Node.
24 | | type Context: Send + Sync;
... |
29 | | async fn run(self, context: Context<Self>) -> Result<Self::Item, Self::Error>;
| |____^
|
note: the return type is pinned boxed `futures::Future` trait object
--> graph/src/node.rs:21:1
|
21 | #[async_trait]
| ^^^^^^^^^^^^^^
help: remove `must_use`
--> graph/src/node.rs:21:1
|
21 | #[async_trait]
| ^^^^^^^^^^^^^^
= note: alternatively, you may add an explicit reason to the `must_use` attribute
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#double_must_use
= note: `-D clippy::double-must-use` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::double_must_use)]`
= note: this error originates in the attribute macro `async_trait` (in Nightly builds, run with -Z macro-backtrace for more info)
```
```
error: use of irregular braces for `format!` macro
--> fs/store/src/local.rs:283:25
|
283 | ...e| format! {"Failed to create local store subdirectory {dest_path:?}: {e}"},
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider writing: `format!("Failed to create local store subdirectory {dest_path:?}: {e}")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#nonstandard_macro_braces
= note: `-D clippy::nonstandard-macro-braces` implied by `-D clippy::all`
= help: to override `-D clippy::all` add `#[allow(clippy::nonstandard_macro_braces)]`
```
tdyas
marked this pull request as ready for review
October 3, 2026 01:11
Contributor
Author
|
The error motivating the async-trait upgrade: |
Contributor
Author
|
benjyw
approved these changes
Oct 15, 2026
sureshjoshi
approved these changes
Oct 15, 2026
Member
https://clippy.rust-lang.org/master/index.html?search=macro_#nonstandard_macro_braces I had to re-review that clippy lint like 10 times, as I thought it was moving braces into parens, which blew my mind. But... Something to be said that any braces can be used with macros. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Rust v1.99.0. There were a few fixes for Clippy lints triggered in this version:
async-traitto a version which avoids triggering a Clippy lint error from generated code.