Skip to content

Create venv repository atomically - #23662

Merged
benjyw merged 6 commits into
pantsbuild:mainfrom
benjyw:create_uv_venv_atomically
Oct 16, 2026
Merged

benjyw merged 6 commits into
pantsbuild:mainfrom
benjyw:create_uv_venv_atomically

Conversation

@benjyw

@benjyw benjyw commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Previously a half-successful creation would leave a broken venv,
requiring nuking the named cache to fix.

Fixes #23657.

@benjyw benjyw added the release-notes:not-required [CI] PR doesn't require mention in release notes label Aug 31, 2026
@benjyw
benjyw force-pushed the create_uv_venv_atomically branch 2 times, most recently from a99697e to 01288cb Compare September 6, 2026 23:02
@benjyw
benjyw force-pushed the create_uv_venv_atomically branch from 01288cb to 87fa02c Compare October 9, 2026 22:31
@benjyw
benjyw requested review from sureshjoshi and tdyas October 15, 2026 20:18
@benjyw
benjyw marked this pull request as ready for review October 15, 2026 20:20

@sureshjoshi sureshjoshi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting that the tests work correctly, as that command is a wild one.

@benjyw
benjyw merged commit 7fa48e0 into pantsbuild:main Oct 16, 2026
28 checks passed
@benjyw

benjyw commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

AI disclosure: Claude helped me review and generate the test.

@benjyw
benjyw deleted the create_uv_venv_atomically branch October 16, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pants 2.33.0 occasionally broken venvs in pants sandboxes with uv resolver

2 participants