Repository navigation
Conversation
pandec
changed the title
pandec
force-pushed
the
fix/emoji-input-command-palette-rename
branch
from
March 28, 2026 07:34
fb86f58 to
daea480
Compare
pandec
commented
Mar 28, 2026
| } | ||
| } | ||
|
|
||
| private struct CommandPaletteTextInputRepresentable: NSViewRepresentable { |
Owner
Author
There was a problem hiding this comment.
I tried keeping the existing SwiftUI TextField / NSTextField path and could not make repeated selected-text emoji replacement stable. The dedicated NSTextView gives the emoji picker a persistent text-input client while preserving single-line rename behavior.
pandec
commented
Mar 28, 2026
| } | ||
|
|
||
| private func firstEditableTextField(in view: NSView) -> NSTextField? { | ||
| private func firstEditableTextInputView(in view: NSView) -> NSView? { |
Owner
Author
There was a problem hiding this comment.
Rename no longer uses the shared field editor, so the palette focus/select-all helpers have to recognize a native NSTextView responder as well as the old NSTextField/field-editor path.
pandec
commented
Mar 28, 2026
| } | ||
| } | ||
|
|
||
| func invalidateTextInputGeometry(for textView: NSTextView) { |
Owner
Author
There was a problem hiding this comment.
These calls are here so AppKit refreshes text geometry after programmatic selection changes; without that, the emoji picker can keep anchoring to stale character coordinates.
pandec
force-pushed
the
fix/emoji-input-command-palette-rename
branch
from
March 28, 2026 11:00
15b6733 to
f9ae7c0
Compare
pandec
pushed a commit
that referenced
this pull request
Oct 15, 2026
* Make bare CodeRouter show account usage * Pin hosted usage support and preserve agent config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSTextViewpath and update palette responder ownership and focus handling so the emoji picker stays attached to the rename field.Related: manaflow-ai#2161
Test plan