Repository navigation
Encode retries exhausted header - #3113
Open
ericwang1409 wants to merge 13 commits into
Open
ericwang1409 wants to merge 13 commits into
ericwang1409 wants to merge 13 commits into
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview✨ Features
|
policy-bot
Bot
dismissed
mpritham’s stale review
October 6, 2026 21:13
Invalidated by push of 84be08c
ericwang1409
changed the title
� Conflicts: � versions.lock
[skip ci]
# Conflicts: # versions.lock # versions.props
ericwang1409
force-pushed
the
elwang/Retries-exhausted-end-to-end-testing
branch
from
October 12, 2026 17:26
8a8d319 to
f1e158a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Dialogue retry exhausted suppressed exception is not encoded in the header sent over the wire. Part of the work to add Dialogue-Retries-Exhausted flag and corresponding metrics.
After this PR
==COMMIT_MSG==
Dialogue retry exhausted flag is encoded to the header if retries are exhausted. End to end tests to check that behavior is as expected. There is also a commit for JMH benchmarking the performance penalty, which is at most 200ns per check depending on the depth of the exception.
==COMMIT_MSG==
Possible downsides?