Repository navigation
Document and adjust change management process - #865
Open
lbarcziova wants to merge 1 commit into
Open
lbarcziova wants to merge 1 commit into
lbarcziova wants to merge 1 commit into
Conversation
PR Summary by QodoPrepare News entries after deployment and document change management
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1. News dates vary with the deployer's timezone
|
![qodo-for-packit[bot]](https://avatars.githubusercontent.com/in/4066991?s=60&v=4){kind=small}
Comment on lines
+712
to
+713
| print("\nNo News entry was generated because release-note lookup failed.") | ||
| return |
There was a problem hiding this comment.
2. Lookup errors leave no news entry 🐞 Bug ☼ Reliability
print_deployment_changelog returns without an entry when release-note collection fails, although the deployment and tag have already succeeded. When GitHub lookup fails, the new post-deployment instructions tell operators to copy a printed entry but provide no retry or manual-publication path.
Agent Prompt
## Issue description
A successful deployment can finish without a News entry if release-note lookup fails, leaving operators unable to follow the new copy-and-publish instructions.
## Fix Focus Areas
- docs/change_management.md[25-30]
- openshift/scripts/deployment_release.py[709-713]
## Recommended Fix
Document how to retry collection for the deployed revision range and manually prepare the tagged News entry if lookup remains unavailable. Point operators to that procedure in the failure output.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
|
||
|
|
||
| def print_deployment_changelog(context: DeploymentContext) -> None: | ||
| deployment_date = datetime.now().astimezone().date() |
There was a problem hiding this comment.
1. News dates vary with the deployer's timezone 🐞 Bug ≡ Correctness
print_deployment_changelog takes the News heading date from the host's local timezone, while proposed_tag_name timestamps deployment tags in UTC. Deployers in different timezones can therefore place deployments from the same UTC date under different News headings, including dates that disagree with the tag shown in the entry.
Agent Prompt
## Issue description
News headings use the deployer's local date, which can differ from the UTC date encoded in the deployment tag.
## Fix Focus Areas
- openshift/scripts/deployment_release.py[705-706]
- openshift/scripts/deployment_release.py[722-725]
## Recommended Fix
Derive the News heading date from the UTC timestamp in the already selected deployment tag, including tags with collision suffixes, so output remains consistent across deployers and delayed release-note lookups.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
lbarcziova
force-pushed
the
news-process
branch
from
October 8, 2026 14:27
13095f1 to
fa472fd
Compare
lbarcziova
commented
Oct 8, 2026
Comment on lines
+10
to
+11
| - **Mailing list:** Send a monthly digest of major features and notable changes | ||
| from News. Send a separate email for bigger announcements. |
Member
Author
There was a problem hiding this comment.
this is open to discussion, whether we want to commit to periodic updates, or rather on major features only
Mainly focuses on gathering the changes and communication to users. Assisted-by: Codex (GPT-6)
lbarcziova
force-pushed
the
news-process
branch
from
October 8, 2026 14:56
fa472fd to
f635581
Compare
opohorel
approved these changes
Oct 9, 2026
opohorel
left a comment
opohorel
left a comment
Collaborator
There was a problem hiding this comment.
from Codex review:
- [P2] A release-note lookup failure can leave a gap in News. The deployment tag is pushed before [release notes are collected](https://github.com/packit/ai-workflows/pull/865/files#diff-4). If GitHub is temporarily unavailable, no News entry is generated. The next deployment starts from that new tag, so it will not collect the skipped changes. The change-management instructions need a recovery step using the previous and new tags, or the deployment flow needs to retain the pending notes.
- [P2] Bulleted PR notes render as nested bullets.
[format_release_note_bullets](https://github.com/packit/ai-workflows/pull/865/files#diff-4)prepends-to the first line without accounting for notes that already begin with a bullet. For- Added a feature, the News entry contains- - Added a feature; I confirmed Markdown renders that as a bullet containing a nested bullet. Normalize the first line or specify and validate plain-text notes.
IMO neither of them is blocking this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Codex (GPT-6)
Merge together with https://gitlab.cee.redhat.com/ymir/ymir.pages.redhat.com/-/merge_requests/23