Repository navigation
Backporting agent: rebasing patches - #73
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new capability for the backporting agent to rebase patches. It also includes configuration changes for the agent's container environment and updates to the agent's tooling and prompts. My review focuses on several key areas. I've identified a hardcoded personal email in the Containerfile and suggested a more robust approach. I've also found critical issues in backport_agent.py, including leftover debugging code that can hang the application and a bug that would cause an UnboundLocalError. Additionally, an invalid type hint in tools/text.py will cause a TypeError. Finally, I've suggested improvements for maintainability regarding a fragile glob pattern. The feedback aims to ensure the code is production-ready, correct, and maintainable.
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
great progress! I like how with the tools the prompts/instructions are more concise
a1e7912 to
418be84
Compare
nforro
left a comment
nforro
left a comment
There was a problem hiding this comment.
I think the first commit is not supposed to be there.
lbarcziova
left a comment
lbarcziova
left a comment
There was a problem hiding this comment.
great changes, thanks a lot! 🚀
64753de to
06859eb
Compare
|
This is now ready for a final review. You can try this easily yourself: |
utilize both instructions and a prompt Signed-off-by: Tomas Tomecek <ttomecek@redhat.com> Co-authored-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
...unless dry_run Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
- add a simple and a complex test case - convert output to StringToolOutput, much simpler - wrap everything in try/except, otherwise errors are not displayed Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Co-authored-by: Nikola Forró <nforro@redhat.com> Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
54b8c22 to
ecb3a89
Compare
3 participants
TODO:
Fixes https://github.com/packit/jotnar/issues/54