Repository navigation
Allow two concurrent tasks on workers - #657
Conversation
Signed-off-by: Nikola Forró <nforro@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increases the maximum concurrent tasks from 1 to 2 in the OpenShift configmap environment configuration. However, this change introduces a critical race condition where concurrent tasks processing the same package will attempt to use and delete the same shared directory path, potentially causing build failures or file corruption. It is recommended to keep the concurrency limit at 1 or update the agent code to use unique directories per merge request.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request increases the maximum concurrent tasks to 2 in the OpenShift configuration and appends a merge request suffix to the Fedora clone directory path. Feedback highlights a critical concurrency issue in rebase_agent.py triggered by increasing concurrent tasks, and suggests a code improvement to reuse local_clone.name instead of parsing the merge request URL again.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: Nikola Forró <nforro@redhat.com> Assisted-by: Claude Opus 4.6 via Claude Code
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request increases the maximum concurrent tasks in the OpenShift configuration, localizes the local_tool_options dictionary inside the workflow functions of the merge request, rebase, and rebuild agents to prevent shared state issues, and updates the Fedora clone directory path to include the local clone name to avoid directory conflicts. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3 participants
No description provided.