Repository navigation
Fix AttributeError in set_jira_fields when target_end is already set - #528
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the check for the TARGET_END_CUSTOM_FIELD field in the Jira tool and updates the corresponding unit tests to handle cases where no fields need updating. The review feedback suggests improving the unit tests by explicitly asserting whether the PUT request mock is called or not using flexmock's expectations.
nforro
approved these changes
Jun 1, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick one-liner fix for when target_end is already set. JIRA returns target_end as a plain date string, not a dict, so .get("value") fails. Changed the check to if not current_target_end and fixed the related tests. I've noticed the failure traces related to this in our MCP gateway logs and while it doesnt seem to affect anything badly it would still be better to have this fixed.