Repository navigation
Enhance Jira issue fetcher - #527
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces configuration options and logic to filter out modular issues and ignored components, and to limit the maximum number of fetched issues via a new MAX_ISSUES parameter. The review feedback highlights critical efficiency and robustness improvements in the issue processing loop: moving the max_issues check to the top of the loop to avoid redundant processing, replacing set subtraction inside the loop with an O(1) membership check to prevent O(N) copies on each iteration, and defensively handling potentially null components fields to avoid a TypeError during parsing.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces filtering capabilities to the Jira issue fetcher, allowing it to skip modular issues and issues belonging to ignored components, as well as limiting the total number of enqueued issues via a new MAX_ISSUES configuration. Feedback on these changes highlights a potential AttributeError when accessing missing fields, a case-sensitivity bug when matching ignored components, and an opportunity to optimize the Jira API pagination loop by breaking early once the MAX_ISSUES limit is reached.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces new filtering and limiting capabilities to the Jira issue fetcher. It adds support for ignoring specific Jira components via IGNORED_COMPONENTS, skipping modular issues based on a regex match on customfield_10669, and limiting the number of fetched issues using MAX_ISSUES. Unit tests have been added to verify these features. The review feedback suggests several improvements: validating that MAX_ISSUES is a positive integer, pre-compiling the modular component regex pattern during initialization to avoid repeated compilation overhead, and adding defensive type checks when extracting components and matching downstream component strings.
Also optionally limit the number of issues to process. Signed-off-by: Nikola Forró <nforro@redhat.com> Assisted-by: Claude Opus 4.6 via Claude Code
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces filtering capabilities to the Jira issue fetcher, allowing it to ignore modular issues and specific components, and adds a configurable limit on the maximum number of issues to process. The review feedback highlights a critical duplication bug that could cause issues to be repeatedly pushed to the queue, a potential startup crash due to unhandled parsing of the MAX_ISSUES environment variable, and an inefficiency where Jira pagination continues even after the maximum issue limit is reached.
Signed-off-by: Nikola Forró <nforro@redhat.com> Assisted-by: Claude Opus 4.6 via Claude Code
Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Nikola Forró <nforro@redhat.com>
4 participants
No description provided.