Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions ymir/agents/backport_agent.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import asyncio
import logging
import os
import re
import sys
import traceback
from pathlib import Path
Expand Down Expand Up @@ -928,6 +929,72 @@ async def create_backport_agent(
)


def _extract_commit_hash(url: str) -> str | None:
"""Extract a commit hash from a dist-git commit URL."""
from urllib.parse import urlparse

parsed = urlparse(url)
match = re.search(r"(?:commit(?:s)?|c)/([a-f0-9]{7,40})", parsed.path)
if match:
return match.group(1)
query_match = re.search(r"(?:id|h)=([a-f0-9]{7,40})", parsed.query or "")
if query_match:
return query_match.group(1)
return None


async def extract_source_changelog(
local_clone: Path, upstream_patches: list[str], package: str
) -> str | None:
"""Extract changelog messages from source dist-git commits.

Iterates all upstream patch URLs, extracts the newest changelog entry
from each commit's spec file, strips Resolves/Related lines, and
combines the descriptive lines (deduplicating across commits).
"""
upstream_clone = Path(f"{local_clone}-upstream")
if not upstream_clone.exists():
return None

collected_lines: list[str] = []
seen: set[str] = set()

for url in upstream_patches:
commit_hash = _extract_commit_hash(url)
if not commit_hash:
continue

try:
stdout, _ = await check_subprocess(
["git", "-C", str(upstream_clone), "show", f"{commit_hash}:{package}.spec"],
)
except Exception:
logger.debug(f"Could not read spec from {commit_hash} in {upstream_clone}")
continue

try:
spec = Specfile(content=stdout, sourcedir=upstream_clone)
with spec.changelog() as changelog:
if not changelog:
continue
entry = changelog[-1]
Comment thread
antbob marked this conversation as resolved.
except Exception:
logger.debug(f"Could not parse spec from {commit_hash}")
continue

for line in entry.content:
if re.match(r"^\s*[-\*]?\s*(resolves|related):", line, re.IGNORECASE):
continue
if line not in seen:
seen.add(line)
collected_lines.append(line)

if not collected_lines:
return None

return "\n".join(collected_lines)


async def main() -> None:
logging.basicConfig(level=logging.INFO)
resolve_chat_model_override("backport")
Expand Down Expand Up @@ -1279,12 +1346,19 @@ async def stage_changes(state):
return "run_log_agent"

async def run_log_agent(state):
source_changelog = await extract_source_changelog(
state.local_clone, state.upstream_patches, state.package
)
if source_changelog:
logger.info(f"Extracted source changelog for reuse: {source_changelog}")

response = await log_agent.run(
render_prompt(
template=get_log_prompt(),
input=LogInputSchema(
jira_issue=state.jira_issue,
changes_summary=state.backport_log[-1],
source_changelog=source_changelog,
),
),
expected_output=LogOutputSchema,
Expand Down
16 changes: 15 additions & 1 deletion ymir/agents/log_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ def get_instructions() -> str:
and could overflow the context. Always examine files one by one.

3. Add a new changelog entry to the spec file. Use the `add_changelog_entry` tool.
Examine the previous changelog entries and try to use the same style. In general,
Examine the previous changelog entries and try to use the same style.

If a source changelog message is provided in the prompt, use those lines as the
exact changelog message content. Keep the descriptive lines exactly as-is — do not
rephrase, summarize, or add to them. Add the Resolves/Related line
for <JIRA_ISSUES>, matching the style of existing changelog entries.

If no source changelog message is provided, write a new entry. In general,
the entry should contain a short summary of the changes, ideally fitting on a single line,
and a single line referencing all Jira issues. Use
"- Resolves: <JIRA_ISSUES>" (comma-separated on one line) unless
Expand Down Expand Up @@ -73,6 +80,13 @@ def get_prompt() -> str:
Document a packaging change done as part of {{jira_issue}} Jira issue(s), summarized as:

{{changes_summary}}

{{#source_changelog}}
The following changelog message was used in the source commit. Use it as the
exact changelog message content:

{{source_changelog}}
{{/source_changelog}}
"""


Expand Down
4 changes: 4 additions & 0 deletions ymir/common/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,10 @@ class LogInputSchema(BaseModel):

jira_issue: str = Field(description="Jira issue to reference as resolved")
changes_summary: str = Field(description="Summary of performed changes")
source_changelog: str | None = Field(
default=None,
description="Changelog message from the source commit to reuse, if available",
)


class LogOutputSchema(BaseModel):
Expand Down
Loading