Repository navigation
Fix dependency check missing clones with stale Y-stream fixVersion - #441
Merged
lbarcziova merged 1 commit intoMay 5, 2026
Merged
Conversation
The Z-stream clone dependency check (used for Y-stream and maintenance eligibility) built its relevant_z_streams set using only the .z form from config (e.g. rhel-9.6.z). Clones with a stale Y-stream fixVersion (rhel-9.6, not yet updated after GA) were silently skipped, potentially unblocking Y-stream/maintenance issues prematurely. Use get_fix_version_variants() to include both forms in the set. Assisted-by: Claude Opus 4.6
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Jira tool to correctly recognize Z-stream clones by including fix version variants. Specifically, it modifies the _check_zstream_clones_shipped function to use get_fix_version_variants, ensuring that versions like rhel-9.6 are matched alongside rhel-9.6.z. A corresponding unit test has been added to verify this behavior. I have no feedback to provide.
majamassarini
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Z-stream clone dependency check (used for Y-stream and maintenance eligibility) built its relevant_z_streams set using only the .z form from config (e.g. rhel-9.6.z). Clones with a stale Y-stream fixVersion (rhel-9.6, not yet updated after GA) were silently skipped, potentially unblocking Y-stream/maintenance issues prematurely.
Use get_fix_version_variants() to include both forms in the set.
Assisted-by: Claude Opus 4.6