Skip to content

Add jotnar_triage_in_progress label that acts as fence - #403

Merged
lbarcziova merged 1 commit into
packit:mainfrom
antbob:triage_in_progress
Apr 14, 2026
Merged

lbarcziova merged 1 commit into
packit:mainfrom
antbob:triage_in_progress

Conversation

@antbob

@antbob antbob commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

When the triage agent pops an issue the item is removed from Redis however if triage workflow is not completed before the Jira issue fetcher runs again this can lead to duplicates. The new label acts as fence to block any issues still under triage from arriving on the queue again.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new TRIAGE_IN_PROGRESS Jira label to track the status of triage tasks and updates the triage_agent.py to manage this label throughout the task lifecycle. A review comment points out a potential race condition in the error handling logic where removing the progress label prematurely could allow duplicate tasks to be initiated while a retry is still pending.

Comment thread agents/triage_agent.py

@TomasTomecek TomasTomecek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also helps people to see that a triage is in progress

so I'm assuming you update your fetcher JQL to omit issues that have triage_in_progress label, right?

@antbob

antbob commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator Author

@TomasTomecek the fetcher skips everything with jotnar label except RETRY_NEEDED.

@lbarcziova
lbarcziova merged commit e5e228c into packit:main Apr 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants