Repository navigation
Add jotnar_triage_in_progress label that acts as fence - #403
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new TRIAGE_IN_PROGRESS Jira label to track the status of triage tasks and updates the triage_agent.py to manage this label throughout the task lifecycle. A review comment points out a potential race condition in the error handling logic where removing the progress label prematurely could allow duplicate tasks to be initiated while a retry is still pending.
TomasTomecek
approved these changes
Apr 14, 2026
TomasTomecek
left a comment
Member
There was a problem hiding this comment.
LGTM, also helps people to see that a triage is in progress
so I'm assuming you update your fetcher JQL to omit issues that have triage_in_progress label, right?
Collaborator
Author
|
@TomasTomecek the fetcher skips everything with jotnar label except RETRY_NEEDED. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the triage agent pops an issue the item is removed from Redis however if triage workflow is not completed before the Jira issue fetcher runs again this can lead to duplicates. The new label acts as fence to block any issues still under triage from arriving on the queue again.