Skip to content

Reset everything after a build failure and let agents start from zero #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nforro merged 1 commit into from
Oct 14, 2025
Merged

Reset everything after a build failure and let agents start from zero #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions agents/backport_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,8 @@ def get_prompt() -> str:

{{.}}

Do your best to fix the issue and then generate a new SRPM.
Everything from the previous attempt has been reset. Start over, follow the instructions from the start
and don't forget to fix the issue.

@TomasTomecek TomasTomecek Oct 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

{{/build_error}}
"""

Expand Down Expand Up @@ -309,7 +310,7 @@ async def run_build_agent(state):
)
return "comment_in_jira"
state.build_error = build_result.error
return "run_backport_agent"
return "fork_and_prepare_dist_git"

@gemini-code-assist gemini-code-assist Bot Oct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change to restart the workflow from fork_and_prepare_dist_git on build failure is a good improvement, as it ensures a clean state for retries.

On a related note, the run_build_agent function is nearly identical in backport_agent.py and rebase_agent.py. This duplication could be addressed in a future refactoring to improve maintainability. Consider moving the common logic to a shared location like agents/package_update_steps.py.

@nforro nforro Oct 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, one day.


async def update_release(state):
try:
Expand Down
5 changes: 3 additions & 2 deletions agents/rebase_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ def get_prompt() -> str:

{{.}}

Do your best to fix the issue and then generate a new SRPM.
Everything from the previous attempt has been reset. Start over, follow the instructions from the start
and don't forget to fix the issue.
{{/build_error}}
"""

Expand Down Expand Up @@ -280,7 +281,7 @@ async def run_build_agent(state):
)
return "comment_in_jira"
state.build_error = build_result.error
return "run_rebase_agent"
return "fork_and_prepare_dist_git"

@gemini-code-assist gemini-code-assist Bot Oct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change to restart the workflow from fork_and_prepare_dist_git on build failure is correct and ensures a clean state for retries.

As with the backport_agent, the run_build_agent function here is almost a direct copy of the one in agents/backport_agent.py. To improve maintainability and reduce code duplication, consider refactoring this shared logic into a common function, for example in agents/package_update_steps.py.


async def update_release(state):
try:
Expand Down