Merged
Conversation
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Member
Author
|
I think it would help if we could refer to the GH releases page/feed instead of maintaining CHANGELOG.md and if @detiber, what are your thoughts on that? (I’ll create an issue to enact it if that sounds reasonable..) I know some folks are not fans of this approach and would rather have the CHANGELOG details in-repo. If that comes up in the issue, the release job can insert the needed lines into the CHANGELOG.md file while it is updating the version in |
detiber
approved these changes
Sep 21, 2021
Contributor
detiber
left a comment
detiber
left a comment
There was a problem hiding this comment.
lgtm
I'm a huge +1 on automating the release notes as much as possible
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the following release:
https://github.com/packethost/packet-python/pull/124/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR12-R17
Should match draft release: https://github.com/packethost/packet-python/releases/tag/untagged-210c609367aedfbb3204 (link will only work for maintainers)
^ This draft can be published upon merge.