add user-agent headers to client requests#113
Merged
Conversation
displague
force-pushed
the
add-user-agent
branch
from
359d16d to
160ef06
Compare
mmlb
previously approved these changes
May 13, 2021
Contributor
mmlb
left a comment
mmlb
left a comment
There was a problem hiding this comment.
lgtm, little bit of stylistic feedback but not worth blocking on
packet/baseapi.py
Outdated
| """ | ||
|
|
||
| def __init__(self, auth_token, consumer_token): | ||
| def __init__(self, auth_token, consumer_token, user_agent=None): |
Contributor
There was a problem hiding this comment.
If you change the default case to
Suggested change
| def __init__(self, auth_token, consumer_token, user_agent=None): | |
| def __init__(self, auth_token, consumer_token, user_agent=""): |
then you don't need the nested format call below.
mmlb
previously approved these changes
May 18, 2021
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104