Fixed broken context search and hide empty categories from filter.#360
Merged
paceholder merged 1 commit intopaceholder:masterfrom Jan 9, 2023
Merged
Fixed broken context search and hide empty categories from filter.#360paceholder merged 1 commit intopaceholder:masterfrom
paceholder merged 1 commit intopaceholder:masterfrom
Conversation
Searching through the context menu was broken after 883e8a0 due to a mis-comparison on node data that is never inserted. This has been fixed by correctly comparing QTreeWidgetItem::text. Furthermore, the filtering system has been changed to hide empty categories, showing only those that are relevant (contain matching nodes). Signed-off-by: Finn Rayment <finn@rayment.fr>
Contributor
Author
|
Tested also on Windows Server 2022 10.0.20348 Build 20348, Qt 5.15.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching through the context menu was broken after 883e8a0 due to a mis-comparison on node data that is never inserted, returning no results. This has been fixed by correctly comparing against
QTreeWidgetItem::text.Furthermore, the filtering system has been changed to hide empty categories, showing only those that are relevant (contain matching nodes).
Tested on Gentoo Linux, kernel 6.1.0, Qt 5.15.7