Conversation
This was referenced May 25, 2023
Open
Downstream consumers (read: propolis) of softnpu utilize the p4rs types in their interactions with this crate. To ensure that the types match up, p4rs is re-exported from this library, and the dependency locked to a git revision. (As opposed to relying on Cargo.lock, which is useless when built as a dependency.)
rcgoodfellow
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream consumers (read: propolis) of softnpu utilize the p4rs types in their interactions with this crate. To ensure that the types match up, p4rs is re-exported from this library, and the dependency locked to a git revision. (As opposed to relying on Cargo.lock, which is useless when built as a dependency.)