Wire up initial support for AMD perf counters#833
Closed
pfmooney wants to merge 1 commit intooxidecomputer:masterfrom
Closed
Wire up initial support for AMD perf counters#833pfmooney wants to merge 1 commit intooxidecomputer:masterfrom
pfmooney wants to merge 1 commit intooxidecomputer:masterfrom
Conversation
iximeow
approved these changes
Jan 24, 2025
gjcolombo
approved these changes
Jan 24, 2025
Contributor
gjcolombo
left a comment
gjcolombo
left a comment
There was a problem hiding this comment.
I'm trying to think of a good PHD test or two to write for this, but this is straightforward enough that I don't think it's worth blocking the PR for. I'll file an issue if I come up with something good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed counterpart to illumos#16906 (CR3865)