[nexus] Support Bundles Datastore methods#7021
Merged
Merged
Conversation
smklein
changed the title
wfchandler
reviewed
Dec 12, 2024
Contributor
wfchandler
left a comment
wfchandler
left a comment
There was a problem hiding this comment.
Thanks @smklein, this looks very nice. Just a question regarding access levels and some nits from me.
wfchandler
approved these changes
Dec 18, 2024
Contributor
wfchandler
left a comment
wfchandler
left a comment
There was a problem hiding this comment.
Nothing further from me, thanks!
smklein
added a commit
that referenced
this pull request
Jan 15, 2025
PR 5 / ??? Implements support bundle APIs for accessing storage bundles. Range request support is only partially implemented as-is -- follow-up support is described in #7356 Builds atop the API skeleton in: - #7008 Uses the support bundle datastore interfaces in: - #7021 Relies on the background task in: - #7063
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 / ???
Adds Support Bundles to the database, along with datastore-specific tests.
These implementations are necessary to implement both the Support Bundle background task,
in #7063 , as well as the HTTP interface for support
bundles, in #7187