Instance create: disable default networking when no default VPC - #3319
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
commented
Aug 12, 2026
| <Radio | ||
| name="networkInterfaceType" | ||
| value="default" | ||
| disabled={!hasVpcs || disabled} |
Collaborator
Author
There was a problem hiding this comment.
This was the wrongest bit.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 29, 2026
oxidecomputer/console@ab7faf6...46f3fd8 * [46f3fd84](oxidecomputer/console@46f3fd84) oxidecomputer/console#3352 * [a6b03812](oxidecomputer/console@a6b03812) oxidecomputer/console#3357 * [b402ebbd](oxidecomputer/console@b402ebbd) oxidecomputer/console#3319 * [b9cea7ea](oxidecomputer/console@b9cea7ea) oxidecomputer/console#3346 * [44646771](oxidecomputer/console@44646771) oxidecomputer/console#3345 * [9e4d3206](oxidecomputer/console@9e4d3206) oxidecomputer/console#3356 * [12edea0f](oxidecomputer/console@12edea0f) oxidecomputer/console#3355 * [21d7c52d](oxidecomputer/console@21d7c52d) oxidecomputer/console#3330 * [dd44146d](oxidecomputer/console@dd44146d) oxidecomputer/console#3353 * [d44615bc](oxidecomputer/console@d44615bc) oxidecomputer/console#3350 * [4f92755b](oxidecomputer/console@4f92755b) oxidecomputer/console#3337 * [b2c28c7d](oxidecomputer/console@b2c28c7d) oxidecomputer/console#3344 * [950767c0](oxidecomputer/console@950767c0) oxidecomputer/console#3343 * [7cd18ad2](oxidecomputer/console@7cd18ad2) oxidecomputer/console#3342 * [5e1f7673](oxidecomputer/console@5e1f7673) oxidecomputer/console#3336 * [37d98e31](oxidecomputer/console@37d98e31) oxidecomputer/console#3332 * [a842fbe7](oxidecomputer/console@a842fbe7) oxidecomputer/console#3335 * [218f3c0f](oxidecomputer/console@218f3c0f) oxidecomputer/console#3334 * [ff240db0](oxidecomputer/console@ff240db0) oxidecomputer/console#3333 * [dfa45c53](oxidecomputer/console@dfa45c53) oxidecomputer/console#3331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason this half-worked is that we were disabling
Defaultwhen there were no VPCs at all. Now we specifically check for a VPC calleddefault. I also improved the styling on a disabled radio button — before the text was normal color and you couldn't tell it was disabled.