Skip to content

github: handle more kinds of incomplete events#113

Open
jclulow wants to merge 1 commit into
mainfrom
bah-github
Open

github: handle more kinds of incomplete events#113
jclulow wants to merge 1 commit into
mainfrom
bah-github

Conversation

@jclulow

@jclulow jclulow commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

We have on occasion received events from GitHub that pretty heavily imply they are not using a strongly typed language in enough of their inner workings. Recently, we received a pull request event where the sender field was entirely absent, and the head of the pull request was not completely filled out:

            head: PullRequestCommit {
                label: None,
                ref_: "tracing-appender-localtime",
                sha: "6b77405e825846c4e6e2cc1ca9544287ef54c12c",
                user: None,
                repo: None,
            },

As we don't currently need those fields, we can just make them optional.

@emilyalbini emilyalbini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of the change looks good to me, but there are a bunch of CI failures on this one :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants