SDPMS-2257 Allow intents to modify external files on lib#6
Merged
pedroccrp merged 9 commits intooxeanbits:masterfrom Sep 11, 2024
Merged
SDPMS-2257 Allow intents to modify external files on lib#6pedroccrp merged 9 commits intooxeanbits:masterfrom
pedroccrp merged 9 commits intooxeanbits:masterfrom
Conversation
pedroccrp
approved these changes
Sep 11, 2024
Collaborator
pedroccrp
left a comment
pedroccrp
left a comment
There was a problem hiding this comment.
Just some minor comments, but it can be merged if it's urgent. Otherwise, it would be good to make these adjustments.
| @@ -1,10 +1,22 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest package="com.xinlan.imageeditandroid" | |||
| <manifest xmlns:tools="http://schemas.android.com/tools" | |||
Collaborator
There was a problem hiding this comment.
Do you know if that’s needed?
Comment on lines
+7
to
+19
| <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" | ||
| android:maxSdkVersion="32" /> | ||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" | ||
| android:maxSdkVersion="32" /> | ||
| <uses-permission | ||
| android:name="android.permission.READ_MEDIA_AUDIO" | ||
| android:minSdkVersion="33" /> | ||
| <uses-permission | ||
| android:name="android.permission.READ_MEDIA_IMAGES" | ||
| android:minSdkVersion="33" /> | ||
| <uses-permission | ||
| android:name="android.permission.READ_MEDIA_VIDEO" | ||
| android:minSdkVersion="33" /> |
Comment on lines
+74
to
+80
| int id = v.getId(); | ||
| if (id == R.id.take_photo) { | ||
| takePhotoClick(); | ||
| } else if (id == R.id.edit_image) { | ||
| editImageClick(); | ||
| } else if (id == R.id.select_ablum) { | ||
| selectFromAblum(); |
Collaborator
There was a problem hiding this comment.
Isn't this the same thing as before?
Comment on lines
+451
to
+455
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { | ||
| albumUpdate(this, saveFilePath); | ||
| } else { | ||
| FileUtil.albumUpdate(this, saveFilePath); | ||
| } |
Collaborator
There was a problem hiding this comment.
Both having the same name makes it really hard to understand the difference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description ✍️
This PR does the following:
Evidences 📱
aaa.mp4