Skip to content

perf(parser): skip redundant member-rest re-scan on call entry #23068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jun 8, 2026
Merged

perf(parser): skip redundant member-rest re-scan on call entry #23068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions crates/oxc_parser/src/js/expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,13 +1029,25 @@ impl<'a, C: Config> ParserImpl<'a, C> {
in_optional_chain: &mut bool,
) -> Expression<'a> {
let mut lhs = lhs;
// The caller only enters here with the current token being `(` or `?.`. For `(`,
// `parse_member_expression_rest` is a no-op (`(` ∉ its FIRST set: `?.`, `.`, `[`,
// template, TS `!`/`<`), so skip the redundant re-scan on entry; entering on `?.`, and
// every later iteration (after `Arguments`), still needs it.
debug_assert!(
matches!(self.cur_kind(), Kind::LParen | Kind::QuestionDot),
"parse_call_expression_rest is only entered on `(` or `?.`",
);
let mut rescan_members = !self.at(Kind::LParen);
while self.fatal_error.is_none() {
lhs = self.parse_member_expression_rest(
lhs_span,
lhs,
in_optional_chain,
/* allow_optional_chain */ true,
);
if rescan_members {
lhs = self.parse_member_expression_rest(
lhs_span,
lhs,
in_optional_chain,
/* allow_optional_chain */ true,
);
}
rescan_members = true;
let question_dot_span = self.at(Kind::QuestionDot).then(|| self.cur_token().span());
let question_dot = question_dot_span.is_some();
if question_dot {
Expand Down
Loading