Skip to content

fix: use an indepentant URL for checking internet connectivtiy#41506

Merged
DeepDiver1975 merged 1 commit intomasterfrom
fix/internet-connectivity-check
Apr 15, 2026
Merged

fix: use an indepentant URL for checking internet connectivtiy#41506
DeepDiver1975 merged 1 commit intomasterfrom
fix/internet-connectivity-check

Conversation

@DeepDiver1975
Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link
Copy Markdown

update-docs bot commented Mar 19, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/internet-connectivity-check branch from 2493ca9 to a9aa0d7 Compare March 19, 2026 07:57
Comment thread config/config.sample.php
/**
* The following URL is used to detect internet connectivity.
*/
'internet_connectivity_detect_url' => 'https://detectportal.firefox.com/success.txt',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this maybe be a list of multiple hostnames where at least one of them required to be reachable? This would allow to circumvent individual destination to be offline and therefore create friction by something the admin of a system doesn't control.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the sake of simplicity I'd like to keep it this way. In 12+y there was no need to ever change this url or even have it configurable. We should be save ;-)

@DeepDiver1975 DeepDiver1975 force-pushed the fix/internet-connectivity-check branch 2 times, most recently from 481fb5d to 2d56f53 Compare March 19, 2026 09:31
@DeepDiver1975 DeepDiver1975 force-pushed the fix/internet-connectivity-check branch from 2d56f53 to b8471e4 Compare April 15, 2026 09:43
@DeepDiver1975 DeepDiver1975 merged commit b9a156a into master Apr 15, 2026
13 checks passed
@DeepDiver1975 DeepDiver1975 deleted the fix/internet-connectivity-check branch April 15, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrity check fails in pure IPv6 networks

3 participants