Deleting unused templated which are related to kf#465
Merged
Conversation
leoraba
approved these changes
Aug 8, 2024
Contributor
leoraba
left a comment
leoraba
left a comment
There was a problem hiding this comment.
LGTM, however I see these templates are still used on manifest/kf/ classes which I suspect those classes are deleted on a separate PR.
Contributor
Author
The templates which you have mentioned are handled in seperate PR, in which we have deleted all those templates which are related to KF or ICGC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of KF-Related Templates
Summary:
The current templates in the SCORe client were originally designed to represent the format related to the Kids First (KF) project. Since the KF project is no longer in use within the SCORe client, we are removing the entire directory associated with these templates.
Details:
Directory Removed:
The folder and all its contents located at score-client/src/main/resources/templates have been completely removed from the repository.
This cleanup helps streamline the codebase and eliminate legacy components that are no longer needed. Please ensure that your workflow does not depend on these templates, as they are now deprecated. #459