Skip to content

Renaming the icgc references to SCORe#452

Merged
Azher2Ali merged 1 commit into
developfrom
refactor/renaming-icgc
Jul 31, 2024
Merged

Renaming the icgc references to SCORe#452
Azher2Ali merged 1 commit into
developfrom
refactor/renaming-icgc

Conversation

@Azher2Ali
Copy link
Copy Markdown
Contributor

@Azher2Ali Azher2Ali commented Jul 24, 2024

Updated SAMFileBuilder in the ViewCommand to use "score" instead of "icgc" for SAMRecord headers, renamed related variables for better generic usage, updated comments in ClientProperties, and replaced ICGC references with "score" in ViewCommand.

Details:

  • Renamed variables in SAMFileBuilder that included "icgc" in their names to be more generic:
  • Updated variable names and their corresponding references to use more appropriate and descriptive names.
  • Modified method getProgramRecordCount() and the clientRecord to reflect these changes.
  • Updated the comment in ClientProperties:
    Changed /** OAuth2 access token for ICGC authorization server / to /* OAuth2 access token for SCORe authorization server */
  • Replaced ICGC variable and value with the string literal "score" in the ViewCommand:

Impact: This update affects the internal labeling and variable naming in the SAMFileBuilder and ViewCommand, making them more adaptable and removing hardcoded references to "icgc". It also updates documentation comments to reflect current usage. These changes do not impact the core functionality of the application. #442

@Azher2Ali Azher2Ali requested review from joneubank and leoraba July 25, 2024 17:12
@Azher2Ali Azher2Ali merged commit 381925a into develop Jul 31, 2024
@Azher2Ali Azher2Ali deleted the refactor/renaming-icgc branch July 31, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants