CORS configurations for score server allowing multiple origins at once#368
Closed
dahiyaAD wants to merge 2 commits into
Closed
CORS configurations for score server allowing multiple origins at once#368dahiyaAD wants to merge 2 commits into
dahiyaAD wants to merge 2 commits into
Conversation
leoraba
reviewed
Jun 2, 2023
| endpoints: | ||
| web: | ||
| cors: | ||
| allowedOrigins: http://example:8080, http://localhost:8081, http://hello:8080 |
Contributor
There was a problem hiding this comment.
can we leave only localhost origin by default? I guess others are just an example, also would be nice to add a comment to describe the value could contain multiple origins separated by commas.
leoraba
approved these changes
Jun 5, 2023
dahiyaAD
force-pushed
the
CORS-configurations
branch
from
e640d99 to
4589f8f
Compare
joneubank
requested changes
Jun 6, 2023
joneubank
left a comment
joneubank
left a comment
Contributor
There was a problem hiding this comment.
Looking for feedback on my suggestion to reorganize the new properties added. Good idea? Bad idea?
Comment on lines
+86
to
+90
| management: | ||
| endpoints: | ||
| web: | ||
| cors: | ||
| allowedOrigins: http://localhost:8081 |
Contributor
There was a problem hiding this comment.
Does it make sense to include the cors settings in the server section of the yaml (line 25)?
would look like:
server:
port: 5431
compression:
enabled: true
mime-types: application/json
cors:
allowedOrigins:
- http://localhost:8081
- http://example.com
Contributor
Author
|
Opened new PR : #369 since the job pr-merge stuck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.