Skip to content

fix: Update CustomAuthHandler to Accpet Async Functions#149

Merged
JamesTLopez merged 2 commits into
mainfrom
fix/accept-async-custom-auth-handler
Jul 9, 2025
Merged

fix: Update CustomAuthHandler to Accpet Async Functions#149
JamesTLopez merged 2 commits into
mainfrom
fix/accept-async-custom-auth-handler

Conversation

@JamesTLopez
Copy link
Copy Markdown
Contributor

@JamesTLopez JamesTLopez commented Jul 8, 2025

Summary

Update Lyric customAuthHandler in provider configurations to accept Asunc Functions

Description of Changes

Special Instructions

Before running these changes, you will need to run:

pnpm i && pnpm build:all

Readiness Checklist

  • Self Review
    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
    • I have checked all updates to correct typos and misspellings
  • Formatting
    • Code follows the project style guide
    • Autmated code formatters (ie. Prettier) have been run
  • Local Testing
    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
  • Updated Tests
    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
  • Documentation
    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

@JamesTLopez JamesTLopez requested review from joneubank and leoraba July 8, 2025 18:57
enabled: boolean;
protectedMethods?: Array<'GET' | 'POST' | 'PUT' | 'DELETE'>;
customAuthHandler?: (req: Request) => UserSessionResult;
customAuthHandler?: (req: Request) => UserSessionResult | Promise<UserSessionResult>;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@leoraba leoraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, approved, just make sure before merging sync this branch with main

@JamesTLopez JamesTLopez merged commit 11cb843 into main Jul 9, 2025
2 checks passed
@JamesTLopez JamesTLopez deleted the fix/accept-async-custom-auth-handler branch July 9, 2025 13:14
@leoraba leoraba mentioned this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants