Skip to content

Create Dictionary saves all dictionary properties#248

Merged
joneubank merged 2 commits into
mainfrom
feat/245-dictionary-description-save
May 21, 2025
Merged

Create Dictionary saves all dictionary properties#248
joneubank merged 2 commits into
mainfrom
feat/245-dictionary-description-save

Conversation

@joneubank
Copy link
Copy Markdown
Contributor

Description

This fixes the issue where Lectern server was not storing or displaying dictionary level description and meta fields.

These fields were not being saved to the database when the create dictionary request was handled.

Fixes

Type of change

Please choose only the relevant options and remove the others.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Updated integration tests to ensure this data is saved

Checklist:

You do not need to fullfill all requirements of this checklist, select all that apply:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@joneubank joneubank merged commit 793fd39 into main May 21, 2025
@joneubank joneubank deleted the feat/245-dictionary-description-save branch May 21, 2025 18:53
justincorrigible pushed a commit to Pan-Canadian-Genome-Library/dictionary-manager that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants