JWT decoder config#887
Merged
Merged
Conversation
Comment on lines
+37
to
+49
| public JwtDecoder jwtDecoder() { | ||
| try { | ||
| if (isPublicKeyConfigured()) { | ||
| return NimbusJwtDecoder.withPublicKey(loadRsaPublicKey()).build(); | ||
| } else if (isJwkSetUriConfigured()) { | ||
| return NimbusJwtDecoder.withJwkSetUri(jwkSetUri).build(); | ||
| } else { | ||
| throw new IllegalStateException("Neither public-key-location nor jwk-set-uri is configured."); | ||
| } | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Failed to configure JwtDecoder", e); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
worth documenting this somewhere (readme?)
Contributor
Author
There was a problem hiding this comment.
Added comments on the application.yml section, where default secure profile is set.
justincorrigible
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR refactors the
JwtDecoderconfiguration to provide a custom bean that dynamically selects between using a public key location or a JWK Set URL.It considers two environment variables:
The
SPRING_SECURITY_OAUTH2_RESOURCESERVER_JWT_PUBLIC_KEY_LOCATIONvariable points to a public key file. This option is used if both environment variables are set.The
SPRING_SECURITY_OAUTH2_RESOURCESERVER_JWT_JWK_SET_URIvariable points to a JWK Set URL.Fixes the Issue:
Type of change
Please choose only the relevant options and remove the others.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
You do not need to fullfill all requirements of this checklist, select all that apply: