Skip to content

Stop polling after repeated query failures - #306

Closed
Tyler-Edwards wants to merge 1 commit into
mainfrom
codex/audit-10-stop-polling-after-repeated-query-failures
Closed

Tyler-Edwards wants to merge 1 commit into
mainfrom
codex/audit-10-stop-polling-after-repeated-query-failures

Conversation

@Tyler-Edwards

Copy link
Copy Markdown
Contributor

What

Stop polling after repeated query failures.

Why

Audit finding 10.

Before After
Polling never reaches its stop threshold. Stop polling after repeated query failures.

Verification

All applicable pre-commit hooks passed. Focused checks on this PR branch passed: Test Files 2 passed (2); Tests 5 passed (5).

pre-commit run --files frontend/src/hooks/use-finetuning.runs.test.ts frontend/src/lib/poll.test.ts frontend/src/lib/poll.ts
cd frontend && bun run typecheck
cd frontend && bun run test -- src/hooks/use-finetuning.runs.test.ts src/lib/poll.test.ts
git diff --check

The combined remediation was also validated before splitting: 943 Console tests, 601 SDK tests on each of Python 3.10 and 3.13, 43 journeys, and four load checks passed. The backend sweep had 3,283 passes and one comparison-contract failure; that contract was fixed and all 15 affected MCP/catalog tests passed on rerun. These combined results are context, not a claim that every suite was rerun on this branch.

Screenshots

Not captured during PR preparation. UI changes remain draft pending browser review.

Completeness

  • MCP — Frontend-only; no MCP catalog change.
  • Blast radius — No Celery routing or seed changes required.
  • Docs — No documentation PR, as requested.
  • Agent instructions — Related agent instructions reviewed; no rule change required.

Checklist

  • The change replaces the affected behavior without a compatibility path.
  • Verification and any skipped suites are reported above.
  • No model fields or migrations changed; this PR is based on current fetched main.
  • UI browser review: pending where applicable; no UI review is claimed.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Tyler-Edwards
Tyler-Edwards deleted the codex/audit-10-stop-polling-after-repeated-query-failures branch November 5, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant