Bump WebKit - #22957
Bump WebKit#22957
Conversation
|
Updated 12:19 AM PT - Sep 26th, 2025
❌ @Jarred-Sumner, your commit 5ba94c4 has 4 failures in
🧪 To try this PR locally: bunx bun-pr 22957That installs a local version of the PR into your bun-22957 --bun |
936a7f5 to
db1e6e7
Compare
- Replace std::variant with WTF::Variant in CryptoGenDhKeyPair.h - Convert WTF::switchOn to std::visit with WTF::makeVisitor pattern: - JSMessageEventCustom.cpp - PerformanceUserTiming.cpp (2 instances) - SerializedScriptValue.cpp - MessageEvent.cpp This addresses the API changes in the new WebKit version where std::variant is now used instead of WTF::Variant in many places, and WTF::switchOn no longer works with std::variant.
- Changed isAsyncFrame() to isAsyncFrameWithoutCodeblock() in ZigGlobalObject.cpp - Converted all WTF::switchOn to std::visit with WTF::makeVisitor in SubtleCrypto.cpp (3 instances)
|
Caution Review failedThe pull request is closed. WalkthroughUpdates default WEBKIT_VERSION in CMake. Converts various variant-dispatch sites from WTF::switchOn to std::visit with WTF::makeVisitor across WebCore and WebCrypto bindings. Adjusts a node crypto header to use WTF::Variant instead of std::variant for a member type. No public API changes. Changes
Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (7)
Comment |
What does this PR do?
How did you verify your code works?