Revive fork changes for async context - #111
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdated PromiseOperations.js to store promise reaction context as either a single context or a pair [context, asyncContext] when an async context is present, affecting creation and enqueueing of reactions. Public/exported declarations were also modified. Changes
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
Comment |
Merged
Jarred-Sumner
pushed a commit
that referenced
this pull request
Sep 4, 2026
https://bugs.webkit.org/show_bug.cgi?id=322128 rdar://185355738 Reviewed by Antti Koivisto. 319240@main parses, computes and serializes the link-parameters property but does not use the computed value, so it has no rendering effect. This PR makes it render the parameters. The most trivial form renders: <style> img { link-parameters: param(--bg, green); } </style> <img src="icon.svg"> <!-- icon.svg: fill="env(--bg, #111)" --> There's a pre-existing architecture limitation: one resource document (SVGImage) holds one container's parameters at a time, so drawing restyles that document. We can reduce this cost by caching a display list per container (webkit.org/b/322833) as a follow-up. Tests: svg/css-link-params/link-parameters-background-image.html svg/css-link-params/link-parameters-basic.html svg/css-link-params/link-parameters-duplicate-name.html svg/css-link-params/link-parameters-dynamic.html svg/css-link-params/link-parameters-fallback.html svg/css-link-params/link-parameters-geometry.html svg/css-link-params/link-parameters-none.html svg/css-link-params/link-parameters-per-container.html * LayoutTests/svg/css-link-params/link-parameters-background-image-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-background-image.html: Added. * LayoutTests/svg/css-link-params/link-parameters-basic-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-basic.html: Added. * LayoutTests/svg/css-link-params/link-parameters-duplicate-name-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-duplicate-name.html: Added. * LayoutTests/svg/css-link-params/link-parameters-dynamic-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-dynamic.html: Added. * LayoutTests/svg/css-link-params/link-parameters-fallback-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-fallback.html: Added. * LayoutTests/svg/css-link-params/link-parameters-geometry-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-geometry.html: Added. * LayoutTests/svg/css-link-params/link-parameters-none-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-none.html: Added. * LayoutTests/svg/css-link-params/link-parameters-per-container-expected.html: Added. * LayoutTests/svg/css-link-params/link-parameters-per-container.html: Added. * LayoutTests/svg/css-link-params/resources/geometry.svg: Added. * LayoutTests/svg/css-link-params/resources/solid.svg: Added. * Source/WebCore/loader/cache/CachedImage.cpp: (WebCore::CachedImage::switchClientsToRevalidatedResource): (WebCore::CachedImage::setContainerContextForClient): (WebCore::CachedImage::createImage): * Source/WebCore/loader/cache/CachedImage.h: * Source/WebCore/style/StyleDifference.cpp: * Source/WebCore/style/StyleEnvironmentVariables.cpp: (WebCore::Style::EnvironmentVariables::uaDefinedValues const): (WebCore::Style::EnvironmentVariables::valueForName const): (WebCore::Style::EnvironmentVariables::setLinkParameters): (WebCore::Style::EnvironmentVariables::values const): Deleted. * Source/WebCore/style/StyleEnvironmentVariables.h: * Source/WebCore/style/StyleSubstitutionResolver.cpp: (WebCore::Style::SubstitutionResolver::propertyValueForVariableName): * Source/WebCore/style/values/images/kinds/StyleCachedImage.cpp: (WebCore::Style::CachedImage::setContainerContextForRenderer): * Source/WebCore/style/values/images/kinds/StyleCursorImage.cpp: (WebCore::Style::CursorImage::setContainerContextForRenderer): * Source/WebCore/svg/graphics/SVGImage.cpp: (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::drawForContainer): (WebCore::SVGImage::applyLinkParameters): (WebCore::SVGImage::drawPatternForContainer): * Source/WebCore/svg/graphics/SVGImage.h: * Source/WebCore/svg/graphics/SVGImageCache.cpp: (WebCore::SVGImageCache::setContainerContextForClient): * Source/WebCore/svg/graphics/SVGImageCache.h: * Source/WebCore/svg/graphics/SVGImageForContainer.cpp: (WebCore::SVGImageForContainer::SVGImageForContainer): (WebCore::SVGImageForContainer::draw): (WebCore::SVGImageForContainer::drawPattern): * Source/WebCore/svg/graphics/SVGImageForContainer.h: Canonical link: https://commits.webkit.org/320159@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#110 partially deleted fork changes for async context by accident.
This patch revives deleted part.