Repository navigation
Tests: fold repeated setup in test_syscall (#497 step 6) - #518
Merged
Merged
Conversation
There was a problem hiding this comment.
Round 1 — reviewed head 60bcef12 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: no defects found.
No findings were reported by any review lens. Rejected findings: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 6 of #497 (fewer, behaviour-focused tests). Tests only;
src/is unchanged.tests/test_syscall.pywas already close to one test per behaviour: no harness call-sequence pins and no large parametrized cross-products. This step only removes repetition. All 75 tests stay, the file goes from 1295 to 1219 lines, and the covered-line sets ofouterloop.syscallandouterloop.syscall_cliare unchanged._job()helper now builds the eval-launch job directories that five tests wrote by hand. Codex review found that the first version of the helper changed two fixtures: thetrainjob lost its empty stderr file, and thebigjob gained an artifacts dir it never had. That moved_deliver_artifactsoff its no-directory path. The helper now reproduces each original fixture exactly.write_req(typed=False)now writes the raw ABI files that two tests created by hand.GLM also dropped three cases:
[None]message items, whitespace-only withdraw reasons, and the symlinkedsync-donemarker. Codex named a realistic regression that each one is the only test for, so all three stay.Left for a later step: split
test_refresh_tool's eight defences; movetest_parse_elapsed_reads_sacct_fieldstotest_compute.py.Built by GLM-5.3 (self-reviewed, coverage-gated, mutation-checked), reviewed by Codex (two rounds; the three deletions dropped and the fixture drift fixed), final read by Claude Opus 5.5.