Repository navigation
Tests: collapse same-path cases in test_inbox.py (#497 step 5) - #511
Merged
Merged
Conversation
There was a problem hiding this comment.
Round 1 — reviewed head c6c9729f — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: no defects found.
No findings were submitted by any review lens. Rejected findings: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5 of #497 (fewer, behaviour-focused tests). Tests only;
src/is unchanged.tests/test_inbox.py: 108 tests (106 passed, 2 skipped) → 90, 1.1 s → 0.7 s, with an identical covered-line set forouterloop.inbox(448/496, the same missing lines).Every collapsed case was mutation-checked: the source was broken the way a regression would break it, a remaining test was confirmed to fail, and the source was reverted.
noteand base-moved share one branch inmessage_text.dirtyas stale would pass without it.readernever changes this render. Unfenced git text is pinned by the legacy base-moved test.""vsNone: these are identical afteror "".Noneis kept.ended:endedis refused insave_record, whichtest_runstate.pypins byte for byte.sourcekey is never read.test_check_log...becomes a substring check. The full wording stays pinned bytest_base_moved_advises_direct_submit.skippedis classified nowhere else, so those cases were restored.Found while doing this, not changed here: no test pins
kernel_text's"refusal:"prefix, and.coverageis not in.gitignore.Built by GLM-5.3 (self-reviewed, coverage-gated, mutation-checked), reviewed by Codex (one dropped case restored in c6c9729), final read by Claude Opus 5.5.