Repository navigation
Tests: slim test_attempt_review.py to behaviour-focused cases (#497 step 2) - #508
Merged
Merged
Conversation
…ert the floor note
There was a problem hiding this comment.
Round 1 — reviewed head 845ede2a — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: no defects found.
No findings were submitted by any review lens. Rejected: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of #497 (fewer, behaviour-focused tests). Tests only;
src/is unchanged.tests/test_attempt_review.py:outerloop.attempt/outerloop.orchestratortest_review_submit_parks_and_delivers_verdictgoes from 12 cases to 4 (plus onegpus=0),test_publish_review_fast_forwards_and_applies_floorfrom 24 to 6 (plus the interrupted report-only recovery), and smaller merges are made in the reply, preflight, ending and scope tests.commit()and the review-GitHub fake are extracted as helpers, and dead contract constants are dropped. One test that byte-duplicated another is deleted.expectedvalue it never used, and its outcome (the "ledger row is unchanged" floor note) was asserted nowhere in the suite. It is now._submit_preflight,gpus=0(CPU submits charge nothing), and interrupted report-only publication recovery. One case each is restored (7929b87).Built by GLM-5.3 (self-reviewed, coverage-gated), reviewed by Codex, final read by Claude Opus 5.5.