Repository navigation
Tests: slim test_orchestrator.py to behaviour-focused cases (#497 step 1) - #507
Merged
Merged
Conversation
…egression note, as run-level assertions
There was a problem hiding this comment.
Round 1 — reviewed head 50dfedac — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: nothing blocking — 2 advisory notes.
2 findings attached to the lines below.
Two non-blocking test-coverage regressions: the report-less submit case no longer enforces a single author session, and the scope-refusal matrix no longer covers timeout budget classification. Rejected findings: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of #497 (fewer, behaviour-focused tests). Tests only;
src/is unchanged.tests/test_orchestrator.py:outerloop.orchestratorattempt_oncecall sites go through the existingrun_climbhelper, so a change to the call is fixed in one place.Built by GLM-5.3 (self-reviewed, coverage-gated), reviewed by Codex, final read by Claude Opus 5.5.