Repository navigation
Cleanup: unreferenced symbols removed, cross-module helpers public in their owners, explicit check=False, logged excepts - #338
Merged
Conversation
…ic in their owners, explicit check=False, logged excepts Digest #332, sections 1, 2 and 8. Unreferenced code removed: - image.containment_available (no caller) - intake.STEWARD_LABEL (no reader; label_name import dropped with it) - tick.read_pending (test-only; the tests that used it as a probe now read through list_pendings, which stays) - housekeeping.shed_candidates (test-only; shed_ended_workspaces uses _is_shed_candidate) and its assertion in test_housekeeping Private helpers imported across modules are public in their owning module: - attempt._target_clone_url -> target_clone_url (followup, tick) - attempt._stage_launch_job_ids -> stage_launch_job_ids (tick) - brief._fence -> code_fence, brief._cap -> cap (intake, followup, steward, syscall, panel); "fence" would shadow the local of the same name at every call site - review_agent._emit -> emit_envelope, review_agent._pull_request -> pull_request (verify_agent, review_summarize_cli, verify_post_cli, review_post_cli, review_agent_cli) - orchestrator._metric_from_output -> metric_from_output (dispatch) No alias kept: nothing under scripts/ or docs/ imports the old names. subprocess.run calls that inspect returncode themselves say check=False: cli._resident_jobs, cli._cancel, cli.start, compute._subprocess_runner, dispatch._filter_neutral_env, github._filter_override_pairs, CodexHarness login. The two `git config --get-regexp` calls exit 1 on "no filter drivers", so raising there would be wrong. Silent excepts log before returning their fallback: attempt._blessed_head (warning), tick._last_worked_ts (debug), init._owner_type (warning; init.py gains a module logger). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…te-imports # Conflicts: # CHANGELOG.md
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Round 1 — reviewed head 2133ac55 — reviewer summarizer:hermes/gpt-5.6-terra over coverage+credentials+deployment+general+lifecycle+prose.
terra
Advisory findings from outerloop — the code owner decides. Reply to disagree; the outerloop:no-review label opts this PR out.
Verdict: no defects found.
Verdict: no findings were reported by any review lens; no findings rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Digest #332, groupings 1, 2 and 8 (dead code, cross-module helpers, small smells). Every claim was grep-verified before acting.
image.containment_available,intake.STEWARD_LABEL(and its now-unusedlabel_nameimport),tick.read_pending(list_pendingsstays; the four probes that used it now calllist_pendings),housekeeping.shed_candidates(shed_ended_workspacesuses_is_shed_candidate, not it). Leftgpus_in_gres,result_summary,parse_result_jsonalone — those are decision items in the digest.brief.code_fence,brief.cap,attempt.target_clone_url,attempt.stage_launch_job_ids,orchestrator.metric_from_output,review_agent.emit_envelope,review_agent.pull_request._fencebecamecode_fencerather thanfencebecause most call sites bind a localfence.check=Falsemade explicit on the sevensubprocess.runcalls that inspectreturncodethemselves (ruff PLW1510); none should raise.attempt(HEAD lookup failed, self-merge not armed),tick._last_worked_ts(unreadable work marker),init(account-type lookup failed).The merge brings in the maintenance module (#334), whose two files imported the old
_emit; retargeted ontoemit_envelopein this branch.One CHANGELOG bullet under Changed (public names moved). No behaviour change.
🤖 Generated with Claude Code