Skip to content

Infra retry count can be lost if the controller crashes between submit and marker write #517

Description

@renmengye

Follow-up from #478 review round 4 (accepted as a known window at merge). Infrastructure retries for an eval that finished without a result are counted in infra-retries.json. If the controller crashes after the retry sbatch succeeds but before the submitted marker is rewritten with the new job id, that retry is never counted, so the two-retry cap can be exceeded by one eval per such crash. Fix: journal the retry before submitting and roll the count back if the submit fails.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions