OSAC-4489: address storage e2e test review findings by jira-autofix[bot] · Pull Request #868 · osac-project/osac

jira-autofix · 2026-09-10T12:00:58Z

Address automated review findings on storage e2e test files from PR #492:

Extract duplicated K8s manifest templates into shared conftest constants
Wrap teardown steps individually to prevent cascading cleanup failures
Let AssertionError propagate from verification steps so they fail the test
Move namespace cleanup out of _verify_teardown into the finally block in test_tenant_storage_lifecycle to prevent namespace leaks
Normalize poll_until checked=False in poll lambdas for consistent error handling
Always verify ClusterOrder removal even on fast deletion path
Assert tenant-scoped secrets are cleaned up during teardown
Add docstrings to all functions and fixtures (coverage improvement from ~7.69%)

openshift-ci-robot · 2026-09-10T12:01:01Z

@jira-autofix[bot]: This pull request references OSAC-4489 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Address automated review findings on storage e2e test files from PR #492:

Extract duplicated K8s manifest templates into shared conftest constants

Wrap teardown steps individually to prevent cascading cleanup failures

Let AssertionError propagate from verification steps so they fail the test

Move namespace cleanup out of _verify_teardown into the finally block in test_tenant_storage_lifecycle to prevent namespace leaks

Normalize poll_until checked=False in poll lambdas for consistent error handling

Always verify ClusterOrder removal even on fast deletion path

Assert tenant-scoped secrets are cleaned up during teardown

Add docstrings to all functions and fixtures (coverage improvement from ~7.69%)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-09-10T12:01:05Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a64cd96c-ac1a-4325-bed2-c5bcb287805e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-10T12:05:35Z

🧭 E2E Suite Selection (POC, informational only)

Suite	Decision	Source	Reason
VMAAS	skip	deterministic	No changed files matched a path rule for this suite
CAAS	skip	deterministic	No changed files matched a path rule for this suite
BMAAS	skip	deterministic	No changed files matched a path rule for this suite

No AI validation needed -- nothing in this PR was recognized as relevant to any E2E suite. This comment is informational only; nothing is gated on it yet.

omer-vishlitzky · 2026-09-18T15:32:57Z

/e2e-ready

omer-vishlitzky · 2026-09-18T15:32:58Z

/ok-to-test

github-actions · 2026-09-18T15:33:18Z

Labeled ok-to-test. Re-ran 2 failed run(s).

github-actions · 2026-09-18T15:33:19Z

Labeled e2e-ready on f6a2ceb. Starting expensive e2e (cleanup removes the label on next push).

osac-ai · 2026-09-18T15:33:19Z

✅ E2E CaaS Full Install -- Passing

Previously failing; now passing as of this run.

✅ E2E BMaaS Full Install -- Passing

Previously failing; now passing as of this run.

✅ E2E VMaaS Full Install -- Passing

Previously failing; now passing as of this run.

_{Total AI diagnostic cost for this PR: $0.4661 (142765 input + 15044 output tokens across 4 diagnoses)}

github-actions · 2026-09-18T15:34:18Z

E2E on `e2e-ready`

Label e2e-ready applied — starting expensive e2e (PR run replay).

Started: 2/3
Already active/green (skipped rerun): 1
Did not POST e2e-*-gate Checks API checks (native jobs report; required gates stay pending until then).

github-actions · 2026-09-18T15:37:30Z

🧭 Jobs Selection (informational only)

E2E Suites

Suite	Decision	Source	Reason
VMAAS	skip	deterministic	No changed files matched a path rule for this suite
CAAS	skip	deterministic	No changed files matched a path rule for this suite
BMAAS	skip	deterministic	No changed files matched a path rule for this suite

No AI validation needed -- nothing in this PR was recognized as relevant to any E2E suite.
_{Estimated cost: $0.0000 (0 input + 0 output tokens, gemini-3.1-pro-preview)}

Unit Tests

Job	Decision	Reason
fulfillment-service	run	This workflow has no per-component scoping -- runs for any non-doc change
osac-metering	run	This workflow has no per-component scoping -- runs for any non-doc change
osac-metering/adapters	run	This workflow has no per-component scoping -- runs for any non-doc change
osac-metering/schema	run	This workflow has no per-component scoping -- runs for any non-doc change

Integration Tests

Job	Decision	Reason
fulfillment-service	run	This workflow has no per-component scoping -- runs for any non-doc change
osac-operator	run	This workflow has no per-component scoping -- runs for any non-doc change
bare-metal-fulfillment-operator	run	This workflow has no per-component scoping -- runs for any non-doc change
osac-aap	run	This workflow has no per-component scoping -- runs for any non-doc change
osac-installer	run	This workflow has no per-component scoping -- runs for any non-doc change

Helm Lint

Job	Decision	Reason
osac-operator	skip	No changed files matched this job's path filter
bare-metal-fulfillment-operator	skip	No changed files matched this job's path filter
fulfillment-service	skip	No changed files matched this job's path filter
osac-aap	skip	No changed files matched this job's path filter
osac-csi-driver	skip	No changed files matched this job's path filter
osac-metering	skip	No changed files matched this job's path filter
osac-installer	skip	No dependent component chart changed

Checks & Builds

Job	Decision	Reason
Check generated code (proto)	skip	No changed files matched this job's path filter
fulfillment-service checks	skip	No changed files matched this job's path filter
Build container image (osac-operator)	skip	No changed files matched this job's path filter
Build container image (bare-metal-fulfillment-operator)	skip	No changed files matched this job's path filter
ansible-lint (osac-aap)	skip	No changed files matched this job's path filter
Darwin keychain tests	skip	No changed files matched this job's path filter

Every table above is informational only -- nothing here gates whether a job actually runs. The E2E Suites table can use AI judgment for ambiguous files; every other table is deterministic-only (no AI).

Harden teardown exception handling in both storage E2E tests so that AssertionError from verification steps propagates and fails the test instead of being silently caught by the blanket except-Exception handler. Assertion errors are collected during teardown and re-raised after all cleanup steps complete, ensuring resource cleanup is never skipped. Move namespace cleanup out of _verify_teardown in test_tenant_storage_lifecycle into the finally block as a separate wrapped step, matching the pattern already used by test_caas_cluster_storage, so that namespace cleanup runs even when verification raises. Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com> Signed-off-by: aipcc-bot <aipcc-bot@redhat.com>

omer-vishlitzky · 2026-09-19T22:14:24Z

/e2e-ready

omer-vishlitzky · 2026-09-19T22:14:25Z

/ok-to-test

github-actions · 2026-09-19T22:14:34Z

Removed ok-to-test label due to new commits. An org member must re-approve with /ok-to-test.

github-actions · 2026-09-19T22:14:42Z

Labeled ok-to-test. Re-ran 1 failed run(s).

github-actions · 2026-09-19T22:14:43Z

Labeled e2e-ready on dc07bf1. Starting expensive e2e (cleanup removes the label on next push).

github-actions · 2026-09-19T22:15:02Z

E2E on `e2e-ready`

Label e2e-ready applied — not starting a new full-install run.

Started: 0/3
Already active/green (skipped rerun): 3
Skipped gate invalidation (full-install already active or in-flight).

zszabo-rh · 2026-09-24T08:02:27Z

/lgtm
/approve

openshift-ci · 2026-09-24T08:02:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jira-autofix[bot], zszabo-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [zszabo-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-09-24T08:02:59Z

E2E on `lgtm`

Label lgtm applied — starting expensive e2e (PR run replay).

Started: 1/3
Already active/green (skipped rerun): 2
Did not POST e2e-*-gate Checks API checks (native jobs report; required gates stay pending until then).

openshift-ci-robot added the jira/valid-reference label Sep 10, 2026

openshift-ci Bot requested review from eranco74 and minmzzhang September 10, 2026 12:01

omer-vishlitzky force-pushed the autofix/osac-4489 branch from 87a3018 to f6a2ceb Compare September 18, 2026 15:32

openshift-ci Bot added the ok-to-test label Sep 18, 2026

github-actions Bot added the e2e-ready label Sep 18, 2026

omer-vishlitzky deployed to e2e-test September 18, 2026 15:34 — with GitHub Actions Active

omer-vishlitzky force-pushed the autofix/osac-4489 branch from f6a2ceb to dc07bf1 Compare September 19, 2026 22:14

github-actions Bot removed the ok-to-test label Sep 19, 2026

github-actions Bot added the ok-to-test label Sep 19, 2026

omer-vishlitzky deployed to e2e-test September 19, 2026 22:14 — with GitHub Actions Active

omer-vishlitzky had a problem deploying to e2e-test September 19, 2026 22:14 — with GitHub Actions Failure

omer-vishlitzky deployed to e2e-test September 19, 2026 22:14 — with GitHub Actions Active

eranco74 added the storage label Sep 22, 2026

openshift-ci Bot assigned zszabo-rh Sep 24, 2026

openshift-ci Bot added the lgtm label Sep 24, 2026

openshift-ci Bot added the approved label Sep 24, 2026

omer-vishlitzky deployed to e2e-test September 24, 2026 08:03 — with GitHub Actions Active

osac-ci-bot enabled auto-merge September 24, 2026 08:27

osac-ci-bot added this pull request to the merge queue Sep 24, 2026

akshaynadkarni requested a review from zszabo-rh September 24, 2026 12:26

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 24, 2026

osac-ci-bot added this pull request to the merge queue Sep 24, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 24, 2026

osac-ci-bot added this pull request to the merge queue Sep 24, 2026

Merged via the queue into main with commit eba2efe Sep 25, 2026
147 of 152 checks passed

Conversation

jira-autofix Bot commented Sep 10, 2026

Uh oh!

openshift-ci-robot commented Sep 10, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Sep 10, 2026

🧭 E2E Suite Selection (POC, informational only)

Uh oh!

omer-vishlitzky commented Sep 18, 2026

Uh oh!

omer-vishlitzky commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

osac-ai Bot commented Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 18, 2026

E2E on e2e-ready

Uh oh!

github-actions Bot commented Sep 18, 2026

🧭 Jobs Selection (informational only)

E2E Suites

Unit Tests

Integration Tests

Helm Lint

Checks & Builds

Uh oh!

omer-vishlitzky commented Sep 19, 2026

Uh oh!

omer-vishlitzky commented Sep 19, 2026

Uh oh!

github-actions Bot commented Sep 19, 2026

Uh oh!

github-actions Bot commented Sep 19, 2026

Uh oh!

github-actions Bot commented Sep 19, 2026

Uh oh!

github-actions Bot commented Sep 19, 2026

E2E on e2e-ready

Uh oh!

zszabo-rh commented Sep 24, 2026

Uh oh!

openshift-ci Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

E2E on lgtm

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Sep 10, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Sep 10, 2026 •

edited

Loading

osac-ai Bot commented Sep 18, 2026 •

edited

Loading

E2E on `e2e-ready`

E2E on `e2e-ready`

E2E on `lgtm`