Skip to content

OSAC-5615: add networking section and auto-provisioned resources to cluster detail page - #1218

Open
redhat-chai-bot wants to merge 1 commit into
osac-project:mainfrom
redhat-chai-bot:feature/OSAC-5615-cluster-networking-section
Open

redhat-chai-bot wants to merge 1 commit into
osac-project:mainfrom
redhat-chai-bot:feature/OSAC-5615-cluster-networking-section

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Summary

Adds the Networking section and Auto-provisioned resources subsection to the cluster detail page's Overview tab.

Resolves OSAC-5615

Changes

New Components

  • ClusterNetworkingCard — displays subnet name (resolved from network_attachment), security groups list, and ingress endpoint with a spinner while the cluster is in PROGRESSING state
  • ClusterAutoProvisionedResources — conditionally rendered subsection (only when autoExternalIpAttachment was true at creation) showing auto-created ExternalIPs and ExternalIPAttachments in a table with Name/Type/State columns

New Hook

  • useClusterAutoProvisionedResources(clusterId, enabled) — queries ExternalIPs and ExternalIPAttachments filtered by auto-created-for label, limit 2 each; both queries disabled when enabled is false

Modified Files

  • ClusterOverviewTab.tsx — wired in ClusterNetworkingCard below ClusterConfigurationCard
  • createMockConnectTransport.ts — added ExternalIPAttachments service and label filter matcher
  • translation.json — added i18n strings for networking section

Testing

11 new tests covering:

  • Rendered subnet name, security groups list
  • Pending ingress endpoint with spinner
  • Resolved ingress endpoint (no spinner)
  • Auto-provisioned subsection hidden when flag is false
  • Auto-provisioned resources table rendering
  • Loading and empty states

Validation

  • pnpm run typecheck ✅
  • pnpm lint ✅
  • pnpm test ✅ (11/11 new tests pass)

AI-generated. Review for accuracy.

@ElayAharoni requested via Chai Bot

…luster detail page

Add a Networking card to the cluster detail Overview tab displaying
the resolved subnet name, security groups list, and ingress endpoint
with a spinner while provisioning. Add an auto-provisioned resources
subsection (visible only when auto_external_ip_attachment was used)
that fetches ExternalIPs and ExternalIPAttachments by the
auto-created-for label and displays them in a status table.

Includes 11 render tests covering networking fields, pending state
spinner, conditional visibility, status labels, and empty state.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Chai Bot <chai-bot@redhat.com>
@openshift-ci-robot

openshift-ci-robot commented Sep 24, 2026 •

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references OSAC-5615 which is a valid jira issue.

Details

In response to this:

Summary

Adds the Networking section and Auto-provisioned resources subsection to the cluster detail page's Overview tab.

Resolves OSAC-5615

Changes

New Components

  • ClusterNetworkingCard — displays subnet name (resolved from network_attachment), security groups list, and ingress endpoint with a spinner while the cluster is in PROGRESSING state
  • ClusterAutoProvisionedResources — conditionally rendered subsection (only when autoExternalIpAttachment was true at creation) showing auto-created ExternalIPs and ExternalIPAttachments in a table with Name/Type/State columns

New Hook

  • useClusterAutoProvisionedResources(clusterId, enabled) — queries ExternalIPs and ExternalIPAttachments filtered by auto-created-for label, limit 2 each; both queries disabled when enabled is false

Modified Files

  • ClusterOverviewTab.tsx — wired in ClusterNetworkingCard below ClusterConfigurationCard
  • createMockConnectTransport.ts — added ExternalIPAttachments service and label filter matcher
  • translation.json — added i18n strings for networking section

Testing

11 new tests covering:

  • Rendered subnet name, security groups list
  • Pending ingress endpoint with spinner
  • Resolved ingress endpoint (no spinner)
  • Auto-provisioned subsection hidden when flag is false
  • Auto-provisioned resources table rendering
  • Loading and empty states

Validation

  • pnpm run typecheck ✅
  • pnpm lint ✅
  • pnpm test ✅ (11/11 new tests pass)

AI-generated. Review for accuracy.

@ElayAharoni requested via Chai Bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign batzionb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: bc91c6da-7cab-4351-8691-a037af1da2b5

📥 Commits

Reviewing files that changed from the base of the PR and between 07154b2 and 5469f7d.

📒 Files selected for processing (8)
  • osac-ui/libs/i18n/locales/en/translation.json
  • osac-ui/libs/ui-components/src/api/v1/cluster.ts
  • osac-ui/libs/ui-components/src/components/Cluster/Details/ClusterAutoProvisionedResources.test.tsx
  • osac-ui/libs/ui-components/src/components/Cluster/Details/ClusterAutoProvisionedResources.tsx
  • osac-ui/libs/ui-components/src/components/Cluster/Details/ClusterNetworkingCard.test.tsx
  • osac-ui/libs/ui-components/src/components/Cluster/Details/ClusterNetworkingCard.tsx
  • osac-ui/libs/ui-components/src/components/Cluster/Details/ClusterOverviewTab.tsx
  • osac-ui/libs/ui-components/src/test-utils/createMockConnectTransport.ts

Comment @coderabbitai help to get the list of available commands.

@osac-ai

osac-ai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

ℹ️ E2E VMaaS Full Install -- Skipped

This suite never reached the point of actually running -- see the run for why (e.g. the e2e-readiness gate wasn't met, or this suite wasn't needed for what changed).

ℹ️ E2E CaaS Full Install -- Skipped

This suite never reached the point of actually running -- see the run for why (e.g. the e2e-readiness gate wasn't met, or this suite wasn't needed for what changed).

ℹ️ E2E BMaaS Full Install -- Skipped

This suite never reached the point of actually running -- see the run for why (e.g. the e2e-readiness gate wasn't met, or this suite wasn't needed for what changed).

@ElayAharoni
ElayAharoni self-requested a review September 24, 2026 15:12
@github-actions

Copy link
Copy Markdown

🧭 Jobs Selection (informational only)

E2E Suites

Suite Decision Source Reason
VMAAS sanity gemini-inconclusive AI judgment was inconclusive for this suite
CAAS sanity gemini-inconclusive AI judgment was inconclusive for this suite
BMAAS sanity gemini-inconclusive AI judgment was inconclusive for this suite

AI judgment confidence: 90%.
Estimated cost: $0.0119 (3910 input + 342 output tokens, gemini-3.1-pro-preview)

Unit Tests

Job Decision Reason
fulfillment-service skip No non-doc changes in this PR (this workflow has no per-component scoping)
osac-metering skip No non-doc changes in this PR (this workflow has no per-component scoping)
osac-metering/adapters skip No non-doc changes in this PR (this workflow has no per-component scoping)
osac-metering/schema skip No non-doc changes in this PR (this workflow has no per-component scoping)

Integration Tests

Job Decision Reason
fulfillment-service skip No non-doc changes in this PR (this workflow has no per-component scoping)
osac-operator skip No non-doc changes in this PR (this workflow has no per-component scoping)
bare-metal-fulfillment-operator skip No non-doc changes in this PR (this workflow has no per-component scoping)
osac-aap skip No non-doc changes in this PR (this workflow has no per-component scoping)
osac-installer skip No non-doc changes in this PR (this workflow has no per-component scoping)

Helm Lint

Job Decision Reason
osac-operator skip No changed files matched this job's path filter
bare-metal-fulfillment-operator skip No changed files matched this job's path filter
fulfillment-service skip No changed files matched this job's path filter
osac-aap skip No changed files matched this job's path filter
osac-csi-driver skip No changed files matched this job's path filter
osac-metering skip No changed files matched this job's path filter
osac-installer skip No dependent component chart changed

Checks & Builds

Job Decision Reason
Check generated code (proto) skip No changed files matched this job's path filter
fulfillment-service checks skip No changed files matched this job's path filter
Build container image (osac-operator) skip No changed files matched this job's path filter
Build container image (bare-metal-fulfillment-operator) skip No changed files matched this job's path filter
ansible-lint (osac-aap) skip No changed files matched this job's path filter
Darwin keychain tests skip No changed files matched this job's path filter

Every table above is informational only -- nothing here gates whether a job actually runs. The E2E Suites table can use AI judgment for ambiguous files; every other table is deterministic-only (no AI).

@ElayAharoni
ElayAharoni requested review from batzionb and rawagner and removed request for batzionb September 24, 2026 15:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants