Skip to content

NO-ISSUE: Move cli-ux rule to fulfillment-service CLI directory - #117

Merged
openshift-merge-bot[bot] merged 1 commit into
osac-project:mainfrom
eranco74:fix/move-cli-ux-rule
Aug 3, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
osac-project:mainfrom
eranco74:fix/move-cli-ux-rule

Conversation

@eranco74

@eranco74 eranco74 commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Move .claude/rules/cli-ux.md to fulfillment-service/internal/cmd/cli/.claude/rules/cli-ux.md
  • The CLI UX guidelines only apply when working on the osac CLI — this scopes the rule so it auto-loads only in that context instead of on every session

Test plan

  • Rule file is valid markdown
  • Git detects it as a rename (no content loss)

Assisted-by: Claude Code noreply@anthropic.com

Summary by CodeRabbit

  • Documentation
    • Updated the CLI description to clearly identify it as the tenant-facing OSAC command-line interface.

The CLI UX guidelines only apply when working on the osac CLI.
Move the rule so it auto-loads only in that context instead of
on every session.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Eran Cohen <eranco@redhat.com>
@openshift-ci-robot

Copy link
Copy Markdown

@eranco74: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Move .claude/rules/cli-ux.md to fulfillment-service/internal/cmd/cli/.claude/rules/cli-ux.md
  • The CLI UX guidelines only apply when working on the osac CLI — this scopes the rule so it auto-loads only in that context instead of on every session

Test plan

  • Rule file is valid markdown
  • Git detects it as a rename (no content loss)

Assisted-by: Claude Code noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e989cb58-56a1-49b6-9f54-a42863e5426e

📥 Commits

Reviewing files that changed from the base of the PR and between 58b0f63 and a76d18c.

📒 Files selected for processing (1)
  • fulfillment-service/internal/cmd/cli/.claude/rules/cli-ux.md

Walkthrough

The CLI UX rule updates the CLI description to refer to the tenant-facing OSAC CLI without its internal repository path.

Changes

CLI description

Layer / File(s) Summary
Update CLI description
fulfillment-service/internal/cmd/cli/.claude/rules/cli-ux.md
The CLI description no longer includes the internal repository path.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes moving the CLI UX rule into the fulfillment-service CLI directory.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The PR only renames the Markdown rule and removes a repository path from one sentence; no secret, credential, token, password, key, or encoded blob was added.
No-Weak-Crypto ✅ Passed The PR only renames a Markdown rule file and changes one CLI description line; scans found no weak-crypto algorithms, crypto implementations, or secret comparisons.
No-Injection-Vectors ✅ Passed The PR changes only a Markdown rule file by moving it and removing a path reference; it contains no executable code or flagged injection pattern.
Container-Privileges ✅ Passed The commit only renames and edits one Markdown rule file; no container/Kubernetes manifest changes or requested privilege indicators were added.
No-Sensitive-Data-In-Logs ✅ Passed The PR only renames the Markdown rule and removes a repository path from one sentence; it adds no logging or sensitive data output.
Ai-Attribution ✅ Passed AI use is stated in the PR and commit; the PR commit includes an Assisted-by trailer and no Co-Authored-By trailer.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, sk-ilya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ajamias pushed a commit to ajamias/osac that referenced this pull request Aug 3, 2026
OSAC-898: Revert per-overlay Bundle naming; use additive selector patching
@openshift-merge-bot
openshift-merge-bot Bot merged commit 31023fa into osac-project:main Aug 3, 2026
27 checks passed
eliorerz pushed a commit that referenced this pull request Sep 18, 2026
OSAC-3382: add identity provider list page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants