add join message with venue indication#30
Open
orenherman wants to merge 4 commits intooriser:mainfrom
Open
Conversation
oriser
reviewed
Jan 23, 2025
Owner
oriser
left a comment
oriser
left a comment
There was a problem hiding this comment.
@orenherman, great addition, it should solve the issue that Wolt introduced with the preview URL on Slack (the restaurant name does not appear in the preview anymore).
Thanks! See small comment :)
Comment on lines
+72
to
+80
| shouldHandleOrder := h.shouldHandleOrder() | ||
| if !shouldHandleOrder { | ||
| _, err := h.informEvent(req.Channel, "It's too late for me... I won't track prices for this order :sleeping:", "", req.MessageID) | ||
| if err != nil { | ||
| return "", errWontJoin | ||
| } | ||
|
|
||
| return "", errNotInTime | ||
| } |
Owner
There was a problem hiding this comment.
Pay attention in the original function, I don't exit immediately in case shouldHandleOrder is false. The reason is that I still want to monitor the order status and the venue availability even if prices should not be tracked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.