Improved pull request "Files Changed" experience feedback #163932
Replies: 2646 comments 1037 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Add File filters to enable the hiding of |
Beta Was this translation helpful? Give feedback.
-
|
Please add back a file filter for "Only files owned by you" |
Beta Was this translation helpful? Give feedback.
-
|
The "New experience" should keep the sticky |
Beta Was this translation helpful? Give feedback.
-
|
Now that swapping between |
Beta Was this translation helpful? Give feedback.
-
|
Would be nice if there was a way to minimize annotations without minimizing human comments! |
Beta Was this translation helpful? Give feedback.
-
|
Probably already reported, but there was a regression, and now diffs are not remaining collapsed when they've been marked as viewed. Also the "changed since last viewed" label isn't showing when it should. These two work in the old experience. |
Beta Was this translation helpful? Give feedback.
-
|
I want to be able to expand all unresolved comments at once (like requested for issues https://github.com/orgs/community/discussions/128155). I wonder whether anyone is able to follow the current requst for feedback, there are over 2.5k comments to expand.
|
Beta Was this translation helpful? Give feedback.
-
|
The header for each individual file diff is not showing up consistently (not sticky) - possibly the same issue as here: https://github.com/orgs/community/discussions/163932#discussioncomment-15582881 I think it might be a bug as sometimes it is there, and other times it is not. Here is an example of it not showing up at all when scrolling (on chrome) After scrolling down, the header is no longer sticky
|
Beta Was this translation helpful? Give feedback.
-
|
Small nit, but the "file-moved" icon being yellow:
and the "file-modified" icon being grey: seems backwards to me. Modifications should be a non-neutral colour and moves should be a neutral colour. |
Beta Was this translation helpful? Give feedback.
-
|
While writing a review comment (in a large PR with multi-file mode if that's relevant), pressing the down or right arrow key at the end of a comment unexpectedly moves the keyboard focus out to select the entire comment (the div with class name My first time using that view, I hit that multiple times when double tapping the arrow key to make sure that I'm at the end of a comment draft after going back to edit something earlier in it |
Beta Was this translation helpful? Give feedback.
-
|
I’d like to be able to filter by multiple filenames or extensions when reviewing code. Sometimes it’s hard to scroll up and down to find related files, especially when one file references another. Often I only want to look at two files at the same time, but currently there’s no way to do that since filtering only supports a single file. |
Beta Was this translation helpful? Give feedback.
-
|
the commit message being less than half of the screen's width on mobile makes it less readable. |
Beta Was this translation helpful? Give feedback.
-
|
I'd like to see how many lines changed for each file in the sidebar. Sometimes I like to review the files with the least changes first, and the GH UI makes it impossible. FWIW, Gitlab already does this |
Beta Was this translation helpful? Give feedback.
-
|
I completed the task |
Beta Was this translation helpful? Give feedback.






















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions