Repository navigation
Fix this-binding: use arrow functions in web LLM service - #9
Merged
Merged
Conversation
RefreshModelService extracts methods as standalone functions (e.g. const listFn = this.llmMessageService.openAICompatibleList) which loses the this context. Converting to arrow function properties ensures this is always bound to the class instance. Co-Authored-By: Danial Piterson <danial.samiei@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this-binding: use arrow functions in web LLM service
Summary
Converts 4 methods in
LLMMessageServiceWebfrom regular class methods to arrow function properties.RefreshModelService.startRefreshingModelsextracts these methods into a standalone variable (const listFn = this.llmMessageService.openAICompatibleList) and calls them directly, which loses thethiscontext. This caused a runtime crash:The fix is purely mechanical —
method(args) {}→method = (args) => {}— forsendLLMMessage,abort,ollamaList, andopenAICompatibleList.Review & Testing Checklist for Human
voidSettingsServiceTypeError in browser console. Open https://ide.orcest.ai/, open DevTools console, and confirm theCannot read properties of undefinederror is gone.Notes
refreshModelService.ts:164-167is pre-existing and used in Electron mode too, but Electron'sLLMMessageServicemethods use IPC channels that don't referencethis, so the bug only manifests in the web stub.Link to Devin run: https://app.devin.ai/sessions/9a3910ef8208402b93e14fa38bb90f2b
Requested by: @danialsamiei