Skip to content

Fix build: run buildreact before compile in Dockerfile - #2

Merged
danialsamiei merged 1 commit into
mainfrom
devin/1771249677-fix-react-build
Feb 16, 2026
Merged

danialsamiei merged 1 commit into
mainfrom
devin/1771249677-fix-react-build

Conversation

@danialsamiei

Copy link
Copy Markdown
Collaborator

Fix build: run buildreact before compile in Dockerfile

Summary

Adds the missing npm run buildreact step before npm run compile in the Dockerfile. The TypeScript compilation depends on pre-built React component outputs (browser/react/out/*/index.js) that are generated by this step. Without it, npm run compile fails with 9 "Cannot find module" errors for the Void UI components (sidebar, settings, tooltip, quick-edit, onboarding, editor-widgets, diff).

The buildreact script (defined in package.json) runs scope-tailwind then tsup inside src/vs/workbench/contrib/void/browser/react/ to produce the out/ directory.

Review & Testing Checklist for Human

  • Verify npm run buildreact succeeds in the Docker build environment. This change has NOT been tested in a Docker build — only inferred from the build error logs and the project's package.json scripts. The buildreact script depends on scope-tailwind, tsup, and cross-spawn being installed and working correctly after npm i --ignore-scripts. If any of these fail silently or need postinstall hooks, the build will still break.
  • Check if --ignore-scripts during npm i breaks scope-tailwind or tsup. The existing Dockerfile uses npm i --ignore-scripts to avoid the ripgrep download issue. Confirm that scope-tailwind and tsup don't require postinstall steps to function.
  • Monitor the Render.com build log after merge to confirm the full pipeline (buildreact → compile → compile-web) completes successfully.

Notes

The React components (sidebar, settings, tooltip, quick-edit, etc.)
must be built before npm run compile, as the TypeScript compilation
depends on the React output files in browser/react/out/.

Adds npm run buildreact step before compile in the Docker build.

Co-Authored-By: Danial Piterson <danial.samiei@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@danialsamiei
danialsamiei merged commit 81f83cb into main Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant