Repository navigation
Fix build: run buildreact before compile in Dockerfile - #2
Merged
Merged
Conversation
The React components (sidebar, settings, tooltip, quick-edit, etc.) must be built before npm run compile, as the TypeScript compilation depends on the React output files in browser/react/out/. Adds npm run buildreact step before compile in the Docker build. Co-Authored-By: Danial Piterson <danial.samiei@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build: run buildreact before compile in Dockerfile
Summary
Adds the missing
npm run buildreactstep beforenpm run compilein the Dockerfile. The TypeScript compilation depends on pre-built React component outputs (browser/react/out/*/index.js) that are generated by this step. Without it,npm run compilefails with 9 "Cannot find module" errors for the Void UI components (sidebar, settings, tooltip, quick-edit, onboarding, editor-widgets, diff).The
buildreactscript (defined inpackage.json) runsscope-tailwindthentsupinsidesrc/vs/workbench/contrib/void/browser/react/to produce theout/directory.Review & Testing Checklist for Human
npm run buildreactsucceeds in the Docker build environment. This change has NOT been tested in a Docker build — only inferred from the build error logs and the project'spackage.jsonscripts. Thebuildreactscript depends onscope-tailwind,tsup, andcross-spawnbeing installed and working correctly afternpm i --ignore-scripts. If any of these fail silently or need postinstall hooks, the build will still break.--ignore-scriptsduringnpm ibreaksscope-tailwindortsup. The existing Dockerfile usesnpm i --ignore-scriptsto avoid the ripgrep download issue. Confirm thatscope-tailwindandtsupdon't require postinstall steps to function.buildreact→compile→compile-web) completes successfully.Notes