Skip to content

Fix settings state: fire event before async storage to ensure React updates #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danialsamiei merged 1 commit into from
Feb 16, 2026
Merged

Fix settings state: fire event before async storage to ensure React updates #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/vs/workbench/contrib/void/common/voidSettingsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,10 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {

dangerousSetState = async (newState: VoidSettingsState) => {
this.state = _validatedModelState(newState)
await this._storeState()
this._onDidChangeState.fire()
this._onUpdate_syncApplyToChat()
this._onUpdate_syncSCMToChat()
await this._storeState()
}
async resetState() {
await this.dangerousSetState(defaultState())
Expand Down Expand Up @@ -360,9 +360,13 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {


private async _storeState() {
const state = this.state
const encryptedState = await this._encryptionService.encrypt(JSON.stringify(state))
this._storageService.store(VOID_SETTINGS_STORAGE_KEY, encryptedState, StorageScope.APPLICATION, StorageTarget.USER);
try {
const state = this.state
const encryptedState = await this._encryptionService.encrypt(JSON.stringify(state))
this._storageService.store(VOID_SETTINGS_STORAGE_KEY, encryptedState, StorageScope.APPLICATION, StorageTarget.USER);
} catch (e) {
console.error('[VoidSettingsService] Failed to store state:', e);
}
}

setSettingOfProvider: SetSettingOfProviderFn = async (providerName, settingName, newVal) => {
Expand Down Expand Up @@ -393,14 +397,13 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
}

this.state = _validatedModelState(newState)

await this._storeState()
this._onDidChangeState.fire()
await this._storeState()

}


private _onUpdate_syncApplyToChat() {
private _onUpdate_syncApplyToChat(){
// if sync is turned on, sync (call this whenever Chat model or !!sync changes)
this.setModelSelectionOfFeature('Apply', deepClone(this.state.modelSelectionOfFeature['Chat']))
}
Expand All @@ -418,10 +421,10 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
}
}
this.state = _validatedModelState(newState)
await this._storeState()
this._onDidChangeState.fire()

// hooks
await this._storeState()
if (this.state.globalSettings.syncApplyToChat) this._onUpdate_syncApplyToChat()
if (this.state.globalSettings.syncSCMToChat) this._onUpdate_syncSCMToChat()

Expand All @@ -438,10 +441,9 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
}

this.state = _validatedModelState(newState)

await this._storeState()
this._onDidChangeState.fire()

await this._storeState()
// hooks
if (featureName === 'Chat') {
// When Chat model changes, update synced features
Expand Down Expand Up @@ -469,9 +471,8 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
}
}
this.state = _validatedModelState(newState)

await this._storeState()
this._onDidChangeState.fire()
await this._storeState()
}

setOverridesOfModel = async (providerName: ProviderName, modelName: string, overrides: Partial<ModelOverrides> | undefined) => {
Expand All @@ -490,8 +491,8 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
};

this.state = _validatedModelState(newState);
await this._storeState();
this._onDidChangeState.fire();
await this._storeState();

this._metricsService.capture('Update Model Overrides', { providerName, modelName, overrides });
}
Expand Down Expand Up @@ -570,8 +571,8 @@ class VoidSettingsService extends Disposable implements IVoidSettingsService {
}
};
this.state = _validatedModelState(newState);
await this._storeState();
this._onDidChangeState.fire();
await this._storeState();
this._metricsService.capture('Set MCP Server States', { newStates });
}

Expand Down